Skip to content

build: Set token permissions for go.yml.#2896

Merged
davecgh merged 1 commit intodecred:masterfrom
arjundashrath:patch-1
Mar 8, 2022
Merged

build: Set token permissions for go.yml.#2896
davecgh merged 1 commit intodecred:masterfrom
arjundashrath:patch-1

Conversation

@arjundashrath
Copy link
Copy Markdown
Contributor

GitHub asks users to define workflow permissions, see https://github.blog/changelog/2021-04-20-github-actions-control-permissions-for-github_token/ and https://docs.github.com/en/actions/security-guides/automatic-token-authentication#modifying-the-permissions-for-the-github_token for securing GitHub workflows against supply-chain attacks.

StepSecurity is working on securing GitHub workflows and OSSF Scorecards recommends using StepSecurity's secure-workflows online tool app.stepsecurity.io to improve the security of GitHub workflows.

This repository has a Scorecards score in the Token-Permissions category of 0/10.

We have fixed one of the repo's workflows for you by adding permissions for the involved jobs. You can secure the rest of the workflows for improved security by using the StepSecurity online tool at app.stepsecurity.io.

Copy link
Copy Markdown
Member

@davecgh davecgh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR. It's a good idea to explicitly specify it in the YAML as well, but for reference, we do have the default permissions set to read-only in the repository settings.

@davecgh davecgh changed the title Set token permissions for go.yml build: Set token permissions for go.yml. Mar 8, 2022
@davecgh davecgh added this to the 1.8.0 milestone Mar 8, 2022
@davecgh davecgh merged commit 3f1fedd into decred:master Mar 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants