update sample-nginx.conf

[chappjc]

Fix the assets location. With the root directive, it would look for
files in /opt/dcrstakepool/public/assets/..., but "assets" is not a
directory that exists in the public folder. Use the alias directive
instead to map all paths under /assets/ to the public/ folder.

Make a comment about ssl_dhparam.

Put ssl and http2 in the port 443 server's listen line.

Add the needed gzip settings.

Disable TLSv1, only using TLSv1.1 and TLSv1.2. Also make a note about
TLSv1.3, which is in newer nginx versions.

Change the http->https rewrite to a return. Use code 308 so that
methods are unchanged (POST stays POST).
https://nginx.org/en/docs/http/ngx_http_rewrite_module.html#return

[jholdstock]

Approving because the changes look fine, but I have not actually tested this file with a real nginx installation. I don't have nginx fronting my dev or test environments (too lazy...)

Maybe @JoeGruffins could check this out, I think he has nginx in front of his test site.

[chappjc]

@JoeGruffins please do test it out since I think you added in the gzip_static block. It wasn't working form me on account of root vs alias, but also I think the "*" in the location wasn't working as intended.

[JoeGruffins]

Also, I find this rate limiting

dcrstakepool/sample-nginx.conf

Line 77 in 8a1fde0

limit_req zone=stakepool burst=5;

to be too restrictive and leads to images not loading

I've always commented that line out. Do you have any better values, or is it a sorta trial error thing?

[chappjc]

Rate limiting was a problem for me too. The assets location can have something with burst:

    limit_req zone=stakepool burst=58 delay=24;

But I'd also raise the sustained limit too.

[chappjc]

@dajohi Looks to be merge-ready.