Merged
Conversation
Member
Author
|
Requesting review from @chappjc |
Member
|
A big benefit of the newer d3 versions is the ability to pick and choose the modules you need. You've opted for the default package, which includes everything, so that works but it's much bigger than needed. See https://github.com/d3/d3/blob/master/API.md. |
Member
Author
|
Done. Previously 1 file at |
- Chart legend is now drawn by d3 rather than manually in the html template - Most of the javascript creating the charts is now in a dedicated file (good progress towards decred#532) - Chart labels are now showing absolute values rather than percentages. This is because percentages are quite easy to estimate by looking at the size of the pie slices, but it is not possible to work out the absolute values. Closes decred#533
jholdstock
force-pushed
the
js-files
branch
from
a845f38 to
8d1ff99
Compare
dajohi
approved these changes
Sep 24, 2019
jyap808
pushed a commit
to ubiq/dcrstakepool
that referenced
this pull request
Dec 16, 2019
ljk662
pushed a commit
to bisontrails/dcrstakepool
that referenced
this pull request
Mar 4, 2020
ljk662
pushed a commit
to bisontrails/dcrstakepool
that referenced
this pull request
Mar 4, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #533