Remove gorilla/context and update deps.#549
Merged
dajohi merged 1 commit intodecred:masterfrom Sep 26, 2019
Merged
Conversation
chappjc
approved these changes
Sep 26, 2019
dajohi
approved these changes
Sep 26, 2019
jyap808
pushed a commit
to ubiq/dcrstakepool
that referenced
this pull request
Dec 16, 2019
ljk662
pushed a commit
to bisontrails/dcrstakepool
that referenced
this pull request
Mar 4, 2020
ljk662
pushed a commit
to bisontrails/dcrstakepool
that referenced
this pull request
Mar 4, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I tested this by running multiple user sessions in multiple browsers/incognito/private browsing sessions. All seems to be working exactly as before, I see no reason for
app.Use(context.ClearHandler).In order to remove gorilla/context from the dependency graph completely I needed to update another Gorilla dependency, so I just ended up running
go get -u; go mod tidy;to update everything.Closes #548