stakepoold: Move rpc/rpcserver to rpc/server#550
Merged
dajohi merged 1 commit intodecred:masterfrom Oct 5, 2019
Merged
Conversation
Closed
f13f75e to
7a694bd
Compare
dajohi
approved these changes
Oct 5, 2019
jyap808
pushed a commit
to ubiq/dcrstakepool
that referenced
this pull request
Dec 16, 2019
ljk662
pushed a commit
to bisontrails/dcrstakepool
that referenced
this pull request
Mar 4, 2020
ljk662
pushed a commit
to bisontrails/dcrstakepool
that referenced
this pull request
Mar 4, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
depends on #529
Suggested by @jholdstock to use the nameing convention:
rpc/server
rpc/client
This moves rpc/rpcserver -> rpc/server as the second rpc is redundant
The current stakepool/client.go file is a wrapper and will be removed asap. I don't think it's worth the trouble to move it now tbh. I will if someone thinks otherwise though.