Cleanup 01 - #8
Merged
Merged
Conversation
we don't want to create a H5Object at address linkInformationOffset but at the address extracted as uint64 from current file at linkInformationOffset. this was merely a typo as the method names for extraction of values are very similar to cpp types.
…data make intention of methods more clear and prevent future bugs.
Contributor
|
I would not reformat any third party code (e.g. bitshuffle, or lz4). |
Contributor
Author
|
will ignore third_party on clang-format! |
Contributor
|
Is it possible to leave formatting out of this PR entirely? It does make it harder to review. |
Contributor
Author
|
removed the reformat |
kalcutter
reviewed
Mar 1, 2021
kalcutter
left a comment
kalcutter
left a comment
Contributor
There was a problem hiding this comment.
The commit message text "move methods only used by class to private" no longer applies does it?
dirkboye
force-pushed
the
cleanup-01
branch
2 times, most recently
from
March 1, 2021 19:27
91f5ae9 to
9cf9bb0
Compare
Contributor
|
LGTM |
* move methods only used by class to private. * refactor H5HeaderMsgPreamble to struct H5HeaderMessage as this only wraps object and type to the outside.
Contributor
Author
|
adapted commit message only. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pullrequest is a first preparation for adding support of HDF5 superblock version 2.