core 4.0.4#79
Merged
Merged
Conversation
## Summary Completes the downstream sync left over from the deepagent context pipeline restructure (f578e4f / eeeac7e), and fixes two regressions found while verifying the Wave 2–5 CLI commands against a live daemon. - Drop orphaned `oversight`/`webhook` HTTP API modules whose service layers were removed by the restructure; the orphaned files broke typecheck and the CLI `oversight` command targeted endpoints that no longer exist. - Fix `dacode run` hanging after completion: the session event stream is now aborted on `session.status idle`, cancelling the underlying SSE fetch connection (the generated SSE client never cancels the fetch in its generator `finally`, leaking the socket and pinning the event loop). - Default missing `apiKey` in the provider discovery cache fetch wrapper. - Restore 6 V4 feature flags (`v4PanelAutoConvene`, `v4AgentPushEnabled`, `v4EventDrivenIm`, `v4MultiAgentRuntime`, `v4EventDrivenArchive`, `v4Steering`) still consumed by app capabilities and test RuntimeFlags overrides. - Complete the goal-driver API sync started in eeeac7e: inline the single-tick logic in `goal-tick-port` (pause/stop check + `loop.tick` + status publish), remove dead steer-relay wiring and dead `maxFilesChanged` / `maxTokensPerHour` gates, and delete/prune tests that targeted removed APIs (`goal-steer`, `overflow`, `plan-status-cache`, `httpapi-webhook`, plus pruned blocks in `steer`, `multi-agent-runtime`, `model-discovery`, `goal-tick-cold-recovery`). ## Test plan - `bun typecheck` across the workspace: deepagent-code package 75 → 0 errors, turbo typecheck 15/15 green. - Manual CLI verification (Wave 2–5 commands): `serve --register` starts and registers cleanly; `run` exits normally (~36s, previously hung past 150s); `debug agents`, `agent list`, `models`, `session list`, `packs list`, `service status` all pass. - Affected tests (`steer`, `goal-tick-cold-recovery`, `multi-agent-runtime`, `model-discovery`): 41 pass / 4 fail — the 4 failures are pre-existing runtime-behavior leftovers from the restructure (baseline was 8 failures on the same files), unrelated to typecheck errors and noted for follow-up.
### Issue for this PR Closes # ### Type of change - [ ] Bug fix - [ ] New feature - [ ] Refactor / code improvement - [ ] Documentation ### What does this PR do? Please provide a description of the issue, the changes you made to fix it, and why they work. It is expected that you understand why your changes work and if you do not understand why at least say as much so a maintainer knows how much to value the PR. **If you paste a large clearly AI generated description here your PR may be IGNORED or CLOSED!** ### How did you verify your code works? ### Screenshots / recordings _If this is a UI change, please include a screenshot or recording._ ### Checklist - [ ] I have tested my changes locally - [ ] I have not included unrelated changes in this PR _If you do not follow this template your PR will be automatically rejected._ --------- Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue for this PR
Closes #
Type of change
What does this PR do?
Please provide a description of the issue, the changes you made to fix it, and why they work. It is expected that you understand why your changes work and if you do not understand why at least say as much so a maintainer knows how much to value the PR.
If you paste a large clearly AI generated description here your PR may be IGNORED or CLOSED!
How did you verify your code works?
Screenshots / recordings
If this is a UI change, please include a screenshot or recording.
Checklist
If you do not follow this template your PR will be automatically rejected.