Fix callbacks to match the expected number of args#39
Merged
deepbrook merged 1 commit intodeepbrook:masterfrom Sep 8, 2018
Merged
Fix callbacks to match the expected number of args#39deepbrook merged 1 commit intodeepbrook:masterfrom
deepbrook merged 1 commit intodeepbrook:masterfrom
Conversation
The callbacks _on_open, _on_message and _on_error provided to WebSocketApp had insufficient number of arguments as expected by websocket-clinet version 0.51.0 (as mentioned in the requirements.txt).
Owner
|
Seriously? What are these nuggets doing. Version |
deepbrook
requested changes
Sep 7, 2018
Owner
deepbrook
left a comment
There was a problem hiding this comment.
Just to be on the safe side, please replace the ws parameter with *args.
squgeim
commented
Sep 8, 2018
deepbrook
approved these changes
Sep 8, 2018
Contributor
|
With the latest Pysher (1.0.3) and the latest websocket-client (0.53.0) I get these errors: Pysher 1.0.1 does not have this problem. I even tried installing websocket-client 0.51.0 to see if it works together with Pysher 1.0.2 but it doesn't. I get the same errors. Comments? |
Contributor
|
The crux of the problem is that websocket-client treats methods as callbacks differently and does not pass the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The callbacks
_on_open,_on_messageand_on_errorprovided toWebSocketApphad insufficient number of arguments as expected bywebsocket-clientversion0.51.0(as mentioned in the requirements.txt).Fixes #38.