Skip to content

Revert "Fix callbacks to match the expected number of args"#45

Merged
deepbrook merged 1 commit intomasterfrom
revert-39-patch-2
Sep 29, 2018
Merged

Revert "Fix callbacks to match the expected number of args"#45
deepbrook merged 1 commit intomasterfrom
revert-39-patch-2

Conversation

@deepbrook
Copy link
Copy Markdown
Owner

Reverts #39

I just hope this is the last we see of this issue.

@deepbrook deepbrook merged commit 8bec816 into master Sep 29, 2018
@craigjmidwinter
Copy link
Copy Markdown
Contributor

hmm, I'm seeing this error on 1.0.4--

2018-12-01 18:11:37 ERROR (PysherEventLoop) [websocket] error from callback <bound method Connection._on_open of <Connection(PysherEventLoop, started daemon 139784776562432)>>: _on_open() takes 1 positional argument but 2 were given
2018-12-01 18:11:37 ERROR (PysherEventLoop) [websocket] error from callback <bound method Connection._on_message of <Connection(PysherEventLoop, started daemon 139784776562432)>>: _on_message() takes 2 positional arguments but 3 were given

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants