Conversation
|
This now depends on #1596. |
brollb
left a comment
brollb
left a comment
There was a problem hiding this comment.
Nice work. I left a couple comments inline.
| services: | ||
| server: | ||
| entrypoint: /.deployment/dev-entrypoint.sh | ||
| entrypoint: /.deployment/dev-entrypoint.sh 8888 |
There was a problem hiding this comment.
I would change the ports that are published - not the port used internally (ie, 8889:8888).
There was a problem hiding this comment.
Ok. I was confused about this. I will change it.
There was a problem hiding this comment.
This has been changed to use default port.
There was a problem hiding this comment.
Why not just omit the extra (unused) code used to allow customization of the default port?
There was a problem hiding this comment.
Yeah. That has been ommitted as well
| id: get_push_tags | ||
| run: | | ||
| echo "::set-env name=TAG::latest" | ||
| echo "::set-env name=RELEASE_TAG::$(echo ${GITHUB_REF:11})" |
There was a problem hiding this comment.
Just to confirm, this will get the number only (remove the leading v from the release tag), right?
As an example the release tag is v2.1.1 whereas the docker image tag is 2.1.1 for the 2.1.1 release.
There was a problem hiding this comment.
No, it will not do that. But the action has an option to set TAG_SEMVER, which will automatically tag all semantic versions accordingly if 1.0.0 then 1, 1.0, 1.0.0 are the three tags set. The Push tag should be refs/branches/master and latest.
There was a problem hiding this comment.
Upon closer inspection of the action code, You can either use custom tags or semver tags, but not both.
https://github.com/elgohr/Publish-Docker-Github-Action/blob/master/entrypoint.sh#L70-L86
There was a problem hiding this comment.
No, it will not do that. But the action...
Wait, so this will not follow the tagging convention when building the release docker images? Could this be updated to follow the conventions?
| tags: "latest" | ||
| tags: "${{ env.TAG }},${{ env.RELEASE_TAG }}" | ||
| dockerfile: Dockerfile.kitchensink | ||
| buildargs: "${{ env.TAG }}" |
There was a problem hiding this comment.
Shouldn't this be TAG=${{ env.TAG}}?
There was a problem hiding this comment.
Yeah. This should be TAG=${{ env.TAG }}
2 participants
Adds a release action to deploy stable docker files to
editor.deepforge.org.ToDos:
stablefromstable-demo