-
Notifications
You must be signed in to change notification settings - Fork 74
Docker Release Action (Closes #1516) #1593
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
32 commits
Select commit
Hold shift + click to select a range
eac8251
WIP- #1516 Add CI test to latest tag
umesh-timalsina 395a13f
WIP- checkout tag in CI step
umesh-timalsina 3734100
Add release tag
umesh-timalsina 1fe3490
WIP- remove wrong - in action file
umesh-timalsina 12bd528
Add docker release action (demo)
umesh-timalsina 0515a1a
Fix indentation in workflow file
umesh-timalsina 3f8633d
WIP-remove npm dry run
umesh-timalsina 14f5a96
WIP- Add a demo release action
umesh-timalsina ffcc356
WIP- Change exposed port in custom-docker-compose-overrides
umesh-timalsina f37ea3d
WIP- Switch to branch before docker build
umesh-timalsina 02272cc
WIP- Switch to branch before docker build
umesh-timalsina e1d2bd8
WIP- Fix branch switching in kitchen-sink image
umesh-timalsina 0e00442
WIP- Add Tag arguments
umesh-timalsina 6b832ab
WIP- Add environment tag arguments as docker build
umesh-timalsina 8485922
Merge branch master into 1516-docker-release-action
umesh-timalsina 6732621
WIP- Move compose customizations to a single file
umesh-timalsina f2e7108
WIP- fix branch checkout
umesh-timalsina d0006b0
WIP- Fix docker-compose command with a uniform project name across di…
umesh-timalsina 15d27eb
WIP- Fix typo in custom overrides file
umesh-timalsina 96f26ac
WIP- add correct mount path for the deployment script
umesh-timalsina 1a97941
WIP- Consolidate action to a single workflow file
umesh-timalsina a74cee3
WIP- Rename TAG environment variables in action files
umesh-timalsina 6e7dda9
WIP- remove branch ref and change images in the overrides file
umesh-timalsina 0f821a4
WIP- Fix kitchensink file
umesh-timalsina 516fdd8
merge branch master into 1516-docker-release-action
umesh-timalsina 81c559b
merge branch master into 1516-deploy-deepforge
umesh-timalsina 528fa76
WIP- Add project name for multidirectory consistency
umesh-timalsina 78ed420
Manually set semver tags for release
umesh-timalsina 7f3e8c7
WIP- remove tag_semver from github action
umesh-timalsina 32d7506
WIP- remove spaces in tag names
umesh-timalsina 727aa49
WIP- Fix semver regex in release docker build action
umesh-timalsina 65492d7
Fixed issue with quotes and refactored sed cmd
brollb File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -5,3 +5,4 @@ pip uninstall tensorflow -y | |
| conda install tensorflow==1.14 -y | ||
|
|
||
| deepforge start --server | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,3 +1,4 @@ | ||
| FROM deepforge/server:latest | ||
| ARG TAG=latest | ||
| FROM deepforge/server:$TAG | ||
|
|
||
| RUN deepforge extensions add deepforge-dev/deepforge-keras && deepforge create-env -f |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just to confirm, this will get the number only (remove the leading
vfrom the release tag), right?As an example the release tag is
v2.1.1whereas the docker image tag is2.1.1for the 2.1.1 release.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, it will not do that. But the action has an option to set
TAG_SEMVER, which will automatically tag all semantic versions accordingly if 1.0.0 then 1, 1.0, 1.0.0 are the three tags set. The Push tag should berefs/branches/masterandlatest.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Upon closer inspection of the action code, You can either use custom tags or
semver tags, but not both.https://github.com/elgohr/Publish-Docker-Github-Action/blob/master/entrypoint.sh#L70-L86
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wait, so this will not follow the tagging convention when building the release docker images? Could this be updated to follow the conventions?