feat: allow monitoring image to collect gpu metrics#8
Merged
Conversation
in order to support using pynvml without blowing up the size of the monitoring docker image, tasks need to run on the non-default batch-debian vm image. This makes google batch set up the nvidia drivers on the vm and mount them to the container instead of relying on the drivers being installed on the monitor image. An added benefit is reduced docker image sizes for all tasks that require a gpu.
Author
|
This change was verified manually by running a workflow with https://github.com/deepgenomics/cromwell-monitor/ as the monitoring image, with both a gpu-enabled task and a non-gpu task, and then viewing Google Batch logs on the console. This area of the code is not covered by existing unit tests. |
SophiaPerzan-DG
approved these changes
Oct 25, 2024
SophiaPerzan-DG
pushed a commit
that referenced
this pull request
Feb 12, 2025
in order to support using pynvml without blowing up the size of the monitoring docker image, tasks need to run on the non-default batch-debian vm image. This makes google batch set up the nvidia drivers on the vm and mount them to the container instead of relying on the drivers being installed on the monitor image. An added benefit is reduced docker image sizes for all tasks that require a gpu. also: fix gh actions syntax error
SophiaPerzan-DG
pushed a commit
that referenced
this pull request
Feb 12, 2025
in order to support using pynvml without blowing up the size of the monitoring docker image, tasks need to run on the non-default batch-debian vm image. This makes google batch set up the nvidia drivers on the vm and mount them to the container instead of relying on the drivers being installed on the monitor image. An added benefit is reduced docker image sizes for all tasks that require a gpu. also: fix gh actions syntax error
SophiaPerzan-DG
pushed a commit
that referenced
this pull request
Feb 20, 2025
in order to support using pynvml without blowing up the size of the monitoring docker image, tasks need to run on the non-default batch-debian vm image. This makes google batch set up the nvidia drivers on the vm and mount them to the container instead of relying on the drivers being installed on the monitor image. An added benefit is reduced docker image sizes for all tasks that require a gpu. also: fix gh actions syntax error
SophiaPerzan-DG
pushed a commit
that referenced
this pull request
Feb 21, 2025
in order to support using pynvml without blowing up the size of the monitoring docker image, tasks need to run on the non-default batch-debian vm image. This makes google batch set up the nvidia drivers on the vm and mount them to the container instead of relying on the drivers being installed on the monitor image. An added benefit is reduced docker image sizes for all tasks that require a gpu. also: fix gh actions syntax error
SophiaPerzan-DG
pushed a commit
that referenced
this pull request
Mar 3, 2025
in order to support using pynvml without blowing up the size of the monitoring docker image, tasks need to run on the non-default batch-debian vm image. This makes google batch set up the nvidia drivers on the vm and mount them to the container instead of relying on the drivers being installed on the monitor image. An added benefit is reduced docker image sizes for all tasks that require a gpu. also: fix gh actions syntax error
SophiaPerzan-DG
pushed a commit
that referenced
this pull request
Jun 4, 2025
in order to support using pynvml without blowing up the size of the monitoring docker image, tasks need to run on the non-default batch-debian vm image. This makes google batch set up the nvidia drivers on the vm and mount them to the container instead of relying on the drivers being installed on the monitor image. An added benefit is reduced docker image sizes for all tasks that require a gpu. also: fix gh actions syntax error
SophiaPerzan-DG
pushed a commit
that referenced
this pull request
Dec 2, 2025
in order to support using pynvml without blowing up the size of the monitoring docker image, tasks need to run on the non-default batch-debian vm image. This makes google batch set up the nvidia drivers on the vm and mount them to the container instead of relying on the drivers being installed on the monitor image. An added benefit is reduced docker image sizes for all tasks that require a gpu. also: fix gh actions syntax error
SophiaPerzan-DG
pushed a commit
that referenced
this pull request
Dec 4, 2025
in order to support using pynvml without blowing up the size of the monitoring docker image, tasks need to run on the non-default batch-debian vm image. This makes google batch set up the nvidia drivers on the vm and mount them to the container instead of relying on the drivers being installed on the monitor image. An added benefit is reduced docker image sizes for all tasks that require a gpu. also: fix gh actions syntax error
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
in order to support using pynvml without blowing up the size of the monitoring docker image, tasks need to run on the non-default batch-debian vm image. This makes google batch set up the nvidia drivers on the vm and mount them to the container instead of relying on the drivers being installed on the monitor image.
An added benefit is reduced docker image sizes for all tasks that require a gpu.