Major DB -> Engine module cleanup work#1473
Conversation
8e199de to
f81c069
Compare
…engine -> io.deephaven.engine, io.deephaven.benchmark.db -> io.deephaven.benchmark.engine
…es relative to the repository root instead of Class objects, in order to allow for module and package name mismatches.
…re standard location.
…uto-refactoring removes but that replication produces)
… JavaDocs, and variable names. Some first draft package moves for RowSequence and related classes.
… unnecessary copyPrev() calls when a non-copying method exists.
JamesXNelson
left a comment
There was a problem hiding this comment.
I only reviewed the .github/workflows/nightly-benchmarks that I am a code-owner for, and it LGTM (simple :path:rename). Did not view the rest of it.
nbauernfeind
left a comment
There was a problem hiding this comment.
Obviously, I cannot review the entire thing. The glances here and there that I've taken all look great. The work I rebased on top is also going well -- so LGTM for merging..
JamesXNelson
left a comment
There was a problem hiding this comment.
Re-adding approval on the .github file, now that nate (and CI) has given a more comprehensive "lgtm"
devinrsmith
left a comment
There was a problem hiding this comment.
Very hard to review. Happy to triage issues later, given all checks are currently passing.
Co-authored-by: Colin Alworth colinalworth@deephaven.io |
This is the bulkiest part of #261
Includes:
io.deephaven.dbpackage name and "Db" in class namesbenchmarksource set.javafiles, rather thanClassobjectsengine/andextensions/with slimmed down dependenciesNULL_BOOLEAN_AS_BYTE != NULL_BYTEdiscrepancy, simplify code #927)