Skip to content

Update DateTime reference to new package location#319

Merged
mofojed merged 2 commits intodeephaven:mainfrom
mofojed:datetime-update
Nov 29, 2021
Merged

Update DateTime reference to new package location#319
mofojed merged 2 commits intodeephaven:mainfrom
mofojed:datetime-update

Conversation

@mofojed
Copy link
Member

@mofojed mofojed commented Nov 29, 2021

DBDateTime is moving due to an engine change, update to use the new name.

Engine PR: deephaven/deephaven-core#1473

DBDateTime is moving due to an engine change, update to use the new name.
@mofojed mofojed added enhancement New feature or request web-client-ui labels Nov 29, 2021
@mofojed mofojed added this to the November 2021 milestone Nov 29, 2021
@mofojed mofojed requested review from niloc132 and vbabich November 29, 2021 16:02
@mofojed mofojed self-assigned this Nov 29, 2021
vbabich
vbabich previously approved these changes Nov 29, 2021
@mofojed
Copy link
Member Author

mofojed commented Nov 29, 2021

Going to wait for @rcaudy 's change to be approved to ensure the final rename.

@vbabich
Copy link
Collaborator

vbabich commented Nov 29, 2021

There's also one com.illumon.iris.db.tables.utils.DBDateTime reference in the API mock in DHE.

@mofojed
Copy link
Member Author

mofojed commented Nov 29, 2021

There's also one com.illumon.iris.db.tables.utils.DBDateTime reference in the API mock in DHE.

That's fine, I don't think this will change on the DHE side.

@mofojed mofojed merged commit 7ef9aa6 into deephaven:main Nov 29, 2021
@mofojed mofojed deleted the datetime-update branch November 29, 2021 22:09
mofojed added a commit to mofojed/web-client-ui that referenced this pull request Dec 3, 2021
* Update DateTime reference to new package location
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request web-client-ui

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants