fix: LivenessStateException with static table in dx and ui#1074
fix: LivenessStateException with static table in dx and ui#1074jnumainville merged 5 commits intodeephaven:mainfrom
dx and ui#1074Conversation
jnumainville
requested review from
a team,
mattrunyon and
niloc132
and removed request for
a team
jnumainville
changed the title
dx and uidx and ui
mattrunyon
left a comment
mattrunyon
left a comment
There was a problem hiding this comment.
Makes me wonder if the liveness scope manage method should handle non-refreshing tables
There was a problem hiding this comment.
Is this blank file needed? Can you put a comment in the file if it is needed for something?
There was a problem hiding this comment.
This is standard for unittest directories for test discovery. That seems like something that wouldn't need a comment to me? There's others as well.
There was a problem hiding this comment.
Guess I never noticed. I figured there would be something in these files
| from deephaven.execution_context import get_exec_ctx | ||
| from deephaven.liveness_scope import liveness_scope | ||
|
|
||
| static_source = new_table([int_col("X", [1, 2, 3])]) |
There was a problem hiding this comment.
From our earlier slack, can this be updated to do one with a live table, and a partitioned table too?
This test successfully validates that the figure can be created in this way, but does it check that the live objects are retained for consumption on the other side, or can we not test the plugin in that way?
There was a problem hiding this comment.
I can add partitioned and live tables easily
I'm not exactly sure how I'd test if the objects are retained correctly. Is there a way to check if an object is being held by a liveness scope or something along those lines? Because I can definitely pull out the tables associated with this figure, simulating when they are sent to the client, but I need some way to check they're retained, unless it's sufficient to do something like dhpd.to_pandas(table) and call it a day
There was a problem hiding this comment.
I think our e2e tests can functionally do that second part - I've added one with a live and partitioned table.
|
plotly-express docs preview (Available for 14 days) |
3 participants
Fixes https://deephaven.atlassian.net/browse/DH-18167
Static tables should not be managed, but they do not error, which leads to errors later, such as in the examples in the issue. Verified that those now work.