feat: Load widgets from plugin context#114
Merged
mofojed merged 5 commits intodeephaven:mainfrom Nov 23, 2023
Merged
Conversation
mattrunyon
force-pushed
the
ui-widget-loading
branch
from
f61b6dd to
9dc12a1
Compare
mofojed
requested changes
Nov 20, 2023
Member
mofojed
left a comment
mofojed
left a comment
There was a problem hiding this comment.
Minor cleanup, marking as requesting changes as we need to update with a published build (0.55 after deephaven/web-client-ui#1644 merges).
mofojed
requested changes
Nov 22, 2023
Member
mofojed
left a comment
mofojed
left a comment
There was a problem hiding this comment.
Rebase off the latest as well to get the latest test-results action
mofojed
approved these changes
Nov 23, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #59
Changes UI to load widgets from the plugin context which allows for any widget (as long as it's a
WidgetPluginw/ the propersupportedTypes) to be part of a deephaven UI panel without any extra setup from the user.