build: DH-19353: Add transpiled files and types to plotly-express build#1170
Merged
mofojed merged 2 commits intodeephaven:mainfrom May 1, 2025
Merged
build: DH-19353: Add transpiled files and types to plotly-express build#1170mofojed merged 2 commits intodeephaven:mainfrom
mofojed merged 2 commits intodeephaven:mainfrom
Conversation
|
plotly-express docs preview (Available for 14 days) |
Member
|
e2e snapshots are failing because missing expansion arrow icon merged to deephaven-core: deephaven/web-client-ui#2406 |
mofojed
approved these changes
May 1, 2025
|
plotly-express docs preview (Available for 14 days) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Just adding back for plotly-express since we weren't publishing types or non-bundled code for the other packages. If we need them in the future we can add them at that time. I didn't want to potentially bork adding them or spend time testing everything is configured properly for other packages if we just need to add the build step back for plotly-express.