fix: Deephaven express memory leak#277
Merged
mofojed merged 1 commit intodeephaven:mainfrom Feb 20, 2024
Merged
Conversation
mofojed
reviewed
Feb 13, 2024
| const columnData = chartData.getColumn( | ||
| column.name, | ||
| val => this.chartUtils.unwrapValue(val), | ||
| this.chartUtils.unwrapValue, |
Member
There was a problem hiding this comment.
Could also set this method in PlotlyExpressChartModel in the construct when we're initializing this.chartUtils, e.g.
this.chartUtils = new ChartUtils(dh);
this.unwrapValue = this.chartUtils.unwrapValue.bind(this.chartUtils);
Collaborator
There was a problem hiding this comment.
Does this work in DHC? I'm getting an error in DHE with the test snippet from #179 -
User callback ( (e2) => this.handleFigureUpdated(e2, id) ) of type updated failed: JavaScriptException {stackTrace: null, backingJsObject: TypeError: Cannot destructure property 'dh' of 'this' as it is undefined. at unwrapValue
With unwrapValue bound to this.chartUtils the charts work fine, haven't checked for memory leaks though.
mattrunyon
force-pushed
the
plotly-express-memory-leak
branch
from
f7ece43 to
53e2bfb
Compare
mattrunyon
force-pushed
the
plotly-express-memory-leak
branch
from
53e2bfb to
1e1d26a
Compare
mattrunyon
force-pushed
the
plotly-express-memory-leak
branch
from
1e1d26a to
631ccad
Compare
mofojed
approved these changes
Feb 16, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #179
Tested by running a server with and without this fix and opening the Memory dev tools tab. Then ran the code in the ticket. The tab without this fix grew steadily in memory consumption over several minutes. The tab with the fix stayed fairly consistent over the same period of time.