build: Only install JS with Python with env var set#285
Merged
mofojed merged 6 commits intodeephaven:mainfrom Feb 16, 2024
Merged
build: Only install JS with Python with env var set#285mofojed merged 6 commits intodeephaven:mainfrom
mofojed merged 6 commits intodeephaven:mainfrom
Conversation
- It's getting it the wheel, but in the `js/build` directory... can we do better? - Ideally it'd be in the deephaven.plot.express.js module
jnumainville
requested changes
Feb 15, 2024
- Renamed _js.py to _js_plugin.py
jnumainville
approved these changes
Feb 15, 2024
mofojed
added a commit
to mofojed/deephaven-plugins
that referenced
this pull request
Feb 22, 2024
- Follow up to deephaven#285, need to enable the environment variable in the Dockerfile so that the docker container works with Deephaven express
mofojed
added a commit
that referenced
this pull request
Feb 22, 2024
- Follow up to #285, need to enable the environment variable in the Dockerfile so that the docker container works with Deephaven express
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Only register the JS if you have the environment variable
DEEPHAVEN_ENABLE_PY_JS=TruesetCleaned up some of the JS in python packaging
deephaven.plot.express.js, so it's contained in the deephaven express package instead of polluting thejsnamespace at the top levelFixes Fix up how JS is packaged with Python #281