Skip to content

fix: Use correct formatting settings for ui.table #326

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mofojed merged 1 commit into from
Feb 28, 2024
Merged

fix: Use correct formatting settings for ui.table #326

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 2 additions & 0 deletions plugins/ui/src/js/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,9 +53,11 @@
"@deephaven/log": "0.62.0",
"@deephaven/plugin": "0.62.0",
"@deephaven/react-hooks": "0.62.0",
"@deephaven/redux": "0.62.0",
"@deephaven/utils": "0.62.0",
"@fortawesome/react-fontawesome": "^0.2.0",
"@react-types/shared": "^3.22.0",
"react-redux": "^7.x",
"json-rpc-2.0": "^1.6.0",
"shortid": "^2.2.16"
},
Expand Down
5 changes: 5 additions & 0 deletions plugins/ui/src/js/src/elements/UITable.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
import React, { useEffect, useMemo, useState } from 'react';
import { useSelector } from 'react-redux';
import {
DehydratedQuickFilter,
IrisGrid,
Expand All @@ -10,6 +11,7 @@ import {
import { useApi } from '@deephaven/jsapi-bootstrap';
import type { Table } from '@deephaven/jsapi-types';
import Log from '@deephaven/log';
import { getSettings } from '@deephaven/redux';
import { UITableProps } from './UITableUtils';

const log = Log.module('@deephaven/js-plugin-ui/UITable');
Expand All @@ -26,6 +28,7 @@ function UITable({
const [model, setModel] = useState<IrisGridModel>();
const [columns, setColumns] = useState<Table['columns']>();
const utils = useMemo(() => new IrisGridUtils(dh), [dh]);
const settings = useSelector(getSettings);

const hydratedSorts = useMemo(() => {
if (sorts !== undefined && columns !== undefined) {
Expand Down Expand Up @@ -81,13 +84,15 @@ function UITable({
showSearchBar: canSearch,
sorts: hydratedSorts,
quickFilters: hydratedQuickFilters,
settings,
}),
[
onRowDoublePress,
alwaysFetchColumns,
canSearch,
hydratedSorts,
hydratedQuickFilters,
settings,
]
);

Expand Down