feat: Export plotly-express as a dashboard plugin#329
Conversation
|
I think this will break plotly-express in DHC w/ dh.ui. We currently check if the plugin is the legacy format first when loading, so the legacy definition (named |
… named export next to the default WidgetPlugin
cb4dc26 to
e8ed513
Compare
|
I added a named export for the legacy |
| ): JSX.Element | null { | ||
| const { id, layout, registerComponent } = props; | ||
|
|
||
| const handlePanelOpen = useCallback( |
There was a problem hiding this comment.
Side note, we have a useDashboardPanel hook that should do what we're doing here, but it would require other changes as well (since it doesn't use metadata or fetch at all). No need to worry about it here.
mattrunyon
left a comment
There was a problem hiding this comment.
I think we'll actually want DHE to register both plugins. Otherwise plotly-express won't work in dh.ui in DHE
|
Why? What plugin type is needed for dh.ui in DHE? |
|
dh.ui reads the plugin registry and looks for |
|
But it should work with just the |
|
Yes once we support |
Tested with DHE V+ (1.20231218.176) Core 0.32.1
Closes #308
BREAKING CHANGE:
widgettype in thePanelEvent.OPENevent arguments has changed fromVariableDefinitiontoVariableDescriptor