Skip to content

feat: Add Python list_view implementation #359

Merged
jnumainville merged 7 commits into
deephaven:mainfrom
jnumainville:337_list_view_impl
Apr 3, 2024
Merged

feat: Add Python list_view implementation #359
jnumainville merged 7 commits into
deephaven:mainfrom
jnumainville:337_list_view_impl

Conversation

@jnumainville
Copy link
Copy Markdown
Collaborator

fixes #337

Adds Python list_view implementation

@jnumainville jnumainville requested a review from mofojed March 14, 2024 16:07
@jnumainville jnumainville self-assigned this Mar 14, 2024
Copy link
Copy Markdown
Member

@mofojed mofojed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Think we should clear up how action_button is populated/used, then we should be good.
Will continue discussion about data sources in Slack team channel.

Comment thread plugins/ui/src/deephaven/ui/components/list_view.py Outdated
Comment thread plugins/ui/src/deephaven/ui/components/list_view.py Outdated
@jnumainville jnumainville requested a review from mofojed April 1, 2024 13:49
Comment thread plugins/ui/DESIGN.md
Comment thread plugins/ui/DESIGN.md
Copy link
Copy Markdown
Member

@mofojed mofojed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, minor doc spec fix. I think we should continue the discussion about item data source as well: #399
But doesn't need to hold this up.

Comment thread plugins/ui/DESIGN.md Outdated
Comment thread plugins/ui/DESIGN.md
Co-authored-by: Mike Bender <mikebender@deephaven.io>
@jnumainville jnumainville requested a review from mofojed April 3, 2024 14:51
@jnumainville jnumainville merged commit f0b8759 into deephaven:main Apr 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ui.list_view python implementation

3 participants