feat: improve default dh.ui layouts#411
Merged
Merged
Conversation
- ui.panel now has default padding and gaps - ui.panel now accepts a subset of flex and view props - ui.panel now wraps children in view and flex containers - ui.panels with only one child (of type grid or plot) have padding removed - ui.flex flex property now defaults to "auto" - ui.flex/ui.view switched to use the wrapped @deephaven/component version - updated package.json to use latest linting rules (to ignore UNSAFE casing) Breaking changes: - ui.panel now has default padding and gaps - ui.flex flex property now defaults to "auto"
bmingles
reviewed
Apr 17, 2024
bmingles
reviewed
Apr 17, 2024
mofojed
requested changes
Apr 17, 2024
Member
mofojed
left a comment
mofojed
left a comment
There was a problem hiding this comment.
Pull the playwright change into a separate PR
mofojed
approved these changes
Apr 17, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Breaking changes: