fix: gapminder to be compatible with Pandas 2.0.3#586
Merged
alexpeters1208 merged 2 commits intomainfrom Jun 27, 2024
Merged
Conversation
alexpeters1208
changed the title
jnumainville
requested changes
Jun 27, 2024
jnumainville
approved these changes
Jun 27, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The current version of the ticking Gapminder dataset uses a feature only available in Pandas 2.1.4. Deephaven will work with Python 3.8, but Pandas 2.1 has a minimum Python version of 3.9. So, the feature that Gapminder depends on is not guaranteed to be available to DH. This PR removes that feature and replicates the functionality with an older feature.