Skip to content

fix: Fixes PartitionedTable has no agg_by error#662

Merged
jnumainville merged 1 commit intodeephaven:mainfrom
jnumainville:661_hist_by_fail
Jul 24, 2024
Merged

fix: Fixes PartitionedTable has no agg_by error#662
jnumainville merged 1 commit intodeephaven:mainfrom
jnumainville:661_hist_by_fail

Conversation

@jnumainville
Copy link
Copy Markdown
Collaborator

@jnumainville jnumainville commented Jul 23, 2024

Fixes #661
create_range_table was not merging the PartitionedTable

Tested with

import deephaven.plot.express as dx
iris = dx.data.iris() # import a ticking version of the Iris dataset

# Ex 1. Each bin is stacked side-by-side for each group
sep_length_multi = dx.histogram(iris, x="sepal_length", by="species")

@jnumainville jnumainville requested a review from mofojed July 23, 2024 23:11
@jnumainville jnumainville self-assigned this Jul 23, 2024
mofojed
mofojed approved these changes Jul 24, 2024
View reviewed changes
Copy link
Copy Markdown
Member

@mofojed mofojed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we add an e2e test as well?

@jnumainville jnumainville merged commit 685c359 into deephaven:main Jul 24, 2024
@jnumainville jnumainville mentioned this pull request Jul 24, 2024
Merged
jnumainville added a commit that referenced this pull request Jul 29, 2024
@jnumainville
fix: Add hist by e2e test and fix error with static plot by (#664)
88eeaea 
Adds e2e test for #662 

Core, as of 35.0, throws an error when a non-refreshing table is passed
to listen to, so added check to bypass that as it doesn't need to be
created anyways.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mofojed mofojed mofojed approved these changes

Assignees

@jnumainville jnumainville

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Using by argument in histogram generates "PartitionedTable has no agg_by" error

2 participants

@jnumainville @mofojed