fix: Prevent pushing broken docs to main#719
Merged
jnumainville merged 9 commits intodeephaven:mainfrom Aug 15, 2024
Merged
Conversation
This was referenced Aug 9, 2024
Merged
Merged
Merged
Merged
mofojed
requested changes
Aug 12, 2024
mofojed
requested changes
Aug 12, 2024
Collaborator
Author
|
@mofojed any further thoughts? |
mofojed
approved these changes
Aug 15, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
make_docs.pyfails correctlymake_docs.ymlnow runs on pull request to main (without sync) so broken docs have to be cleaned up before mergetext_area.pyso docs are able to buildTested on my fork