docs: ui.radio_group#758
Conversation
|
Should be good now to review |
Co-authored-by: Don <dsmmcken@gmail.com>
Co-authored-by: Don <dsmmcken@gmail.com>
…/deephaven-plugins into 765_radio_group_docs
|
I see you added value everywhere. Is value always required? I thought it was optional and used the label? If so, I would show some options like that. |
There was a problem hiding this comment.
@dsmmcken This is interesting, just tried some examples, and it appears that if we do not currently set the value to be the label, if the value is not provided.
The value by default is set to None, so I guess there are two options:
a. Create a ticket to make it so that it sets the value to the label by default, and then include the fact that the value is an optional prop.
b. Do not make any changes to the current logic, and enforce that users have to set value
I am more in favor of A, but open to either
|
I think it should work automatticaly as you describe with option A. I mean that's what you had initially actually tried, so it seems like thats how one would expect it to work. This of course only applies if contents of the label are a string, and not anything more complex (not sure if it accepts icons + text for example, in which case a value would be required. @mofojed thoughts? |
|
@AkshatJawne Please ticket this, and also we should make sure checkbox/checbox_group also behaves the same way, as looking at checkbox docs I don't see it talking about the value prop at all. |
|
Created ticket: #765 |

Closes #756