fix: contextual_help uses heading, content, footer props#945
Merged
wusteven815 merged 2 commits intoOct 21, 2024
Conversation
dgodinez-dh
requested changes
Oct 21, 2024
dgodinez-dh
approved these changes
Oct 21, 2024
dsmmcken
approved these changes
Oct 21, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ui.contextual_helpcontent not rendering properly #926heading,content, andfooterprops in their respective componentBREAKING CHANGE:
ui.contextual_help's signature replaces the*childrenprop withheading,content, andfooterprops, in that order. In parity with React Spectrum docs, theheadingandcontentprops are required andfooteris optional.Here are some examples of usages and how they might change: