feat: UI Dialog and DialogTrigger Components#953
Merged
Conversation
dgodinez-dh
requested review from
a team and
bmingles
and removed request for
a team
bmingles
previously approved these changes
Oct 28, 2024
Contributor
bmingles
left a comment
bmingles
left a comment
There was a problem hiding this comment.
I reviewed the new boolean hook. Changes look good to me.
jnumainville
requested changes
Oct 31, 2024
Co-authored-by: Joe <josephnumainville@deephaven.io>
jnumainville
previously approved these changes
Oct 31, 2024
mofojed
previously approved these changes
Oct 31, 2024
Co-authored-by: margaretkennedy <82049573+margaretkennedy@users.noreply.github.com>
dgodinez-dh
dismissed stale reviews from mofojed and jnumainville
via
d021d43
margaretkennedy
approved these changes
Nov 1, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #933
closes #863
Note that there is a bug in the spectrum theme that causes the underlay to render as transparent. It is fixed here:
deephaven/web-client-ui#2267
The underlay may render incorrectly depending on your version of
web-client-uiBecause of this bug, we are waiting for a new version before adding a render test for dialog. See #952