fix: Remove frequency_bar#955
Merged
jnumainville merged 4 commits intodeephaven:mainfrom Oct 25, 2024
Merged
Conversation
jnumainville
requested review from
a team and
mattrunyon
and removed request for
a team
mattrunyon
previously approved these changes
Oct 23, 2024
margaretkennedy
previously approved these changes
Oct 23, 2024
mofojed
requested changes
Oct 24, 2024
Member
mofojed
left a comment
mofojed
left a comment
There was a problem hiding this comment.
Does frequency_bar no longer work at all? We shouldn't just remove APIs and cause breaking changes, we should be deprecating it first.
Collaborator
Author
|
Yes in the current version of this PR it was completely removed. I'll deprecate the existing path instead. We never documented it beyond it being available in the API because it has been marked for removal long ago so hopefully we can remove it soon. |
jnumainville
dismissed stale reviews from margaretkennedy and mattrunyon
via
1a45a36
mofojed
previously approved these changes
Oct 24, 2024
mofojed
approved these changes
Oct 24, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #66
BREAKING: frequency_bar is no longer supported. Instead, only pass one of x or y into bar.