Skip to content

DH-11336 support Layout Hints on web#208

Merged
spasovski merged 11 commits intodeephaven:mainfrom
spasovski:davor_DH-11336_ui
Oct 15, 2021
Merged

DH-11336 support Layout Hints on web#208
spasovski merged 11 commits intodeephaven:mainfrom
spasovski:davor_DH-11336_ui

Conversation

@spasovski
Copy link
Contributor

This handles .hide(), .atFront() and .atEnd(). A separate ticket and PR will address .freeze().

@spasovski spasovski requested a review from mofojed September 22, 2021 20:50
@spasovski spasovski self-assigned this Sep 22, 2021
@mofojed mofojed self-requested a review September 30, 2021 17:22
@spasovski spasovski requested a review from mofojed October 4, 2021 16:33
@spasovski spasovski requested a review from mofojed October 6, 2021 15:24
@spasovski spasovski requested a review from mofojed October 8, 2021 15:18
Copy link
Member

@mofojed mofojed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We'll need to update the use of table.columns in PartitionSelectorSearch, AdvancedFilterCreatorSelectValue, and AdvancedFilterCreatorSelectValueList as well.

Copy link
Member

@mofojed mofojed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We'll need to update the use of table.columns in PartitionSelectorSearch, AdvancedFilterCreatorSelectValue, and AdvancedFilterCreatorSelectValueList as well.

@spasovski
Copy link
Contributor Author

It seems we won't need to update the table.columns references in PartitionSelectorSearch, AdvancedFilterCreatorSelectValue, and AdvancedFilterCreatorSelectValueList since they are model.valuesTable. We could consider renaming table in these components however.

@spasovski spasovski requested a review from mofojed October 14, 2021 19:49
@spasovski spasovski merged commit c4f525a into deephaven:main Oct 15, 2021
@spasovski spasovski deleted the davor_DH-11336_ui branch October 15, 2021 20:52
@mofojed mofojed mentioned this pull request Oct 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants