Change some utils to use columns array instead of entire model#254
Merged
mattrunyon merged 1 commit intodeephaven:mainfrom Oct 21, 2021
Merged
Change some utils to use columns array instead of entire model#254mattrunyon merged 1 commit intodeephaven:mainfrom
mattrunyon merged 1 commit intodeephaven:mainfrom
Conversation
spasovski
approved these changes
Oct 21, 2021
Contributor
spasovski
left a comment
spasovski
left a comment
There was a problem hiding this comment.
Looks good - I like the idea of sending the columns directly.
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to #208 and tangentially #229
This changes specific utils to not take the entire model since they don't really need the whole model. For things that hydrate/dehydrate the entire grid or panel, the model is still passed even though it is only used for its columns as those methods might make use of the model in the future.
Also reverts
applySettingsToTableto use a table because the only place it is called has a table that does not have a model associated with it. The table is then used to create a chart.