feat: XComponents and Core plugins cleanup#2137
Closed
mofojed wants to merge 4 commits intodeephaven:mainfrom
Closed
feat: XComponents and Core plugins cleanup#2137mofojed wants to merge 4 commits intodeephaven:mainfrom
mofojed wants to merge 4 commits intodeephaven:mainfrom
Conversation
- Cleaning up this feature branch
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2137 +/- ##
==========================================
+ Coverage 46.63% 46.73% +0.09%
==========================================
Files 682 689 +7
Lines 38443 38490 +47
Branches 9580 9780 +200
==========================================
+ Hits 17928 17988 +60
+ Misses 20505 20450 -55
- Partials 10 52 +42
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
- Instead of using PanelEvent.OPEN directly and not getting any type safety, add functions for emitting, listening, and a hook to enforce type safety
Member
Author
|
PR #2144 for merging the latest changes into the feature branch. Then we'll merge the feature branch into main. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.