Skip to content

feat: XComponents and Core plugins cleanup#2137

Closed
mofojed wants to merge 4 commits intodeephaven:mainfrom
mofojed:core-plugins-refactor-clean
Closed

feat: XComponents and Core plugins cleanup#2137
mofojed wants to merge 4 commits intodeephaven:mainfrom
mofojed:core-plugins-refactor-clean

Conversation

@mofojed
Copy link
Copy Markdown
Member

@mofojed mofojed commented Jul 9, 2024

No description provided.

@codecov
Copy link
Copy Markdown

codecov Bot commented Jul 9, 2024

Codecov Report

Attention: Patch coverage is 76.47059% with 32 lines in your changes missing coverage. Please review.

Project coverage is 46.73%. Comparing base (c9ed895) to head (fb5c0f5).
Report is 2 commits behind head on main.

Files Patch % Lines
.../dashboard-core-plugins/src/panels/WidgetPanel.tsx 47.05% 9 Missing ⚠️
packages/code-studio/src/main/AppMainContainer.tsx 0.00% 6 Missing ⚠️
...ckages/dashboard-core-plugins/src/panels/Panel.tsx 75.00% 5 Missing ⚠️
...ard-core-plugins/src/panels/WidgetPanelTooltip.tsx 20.00% 4 Missing ⚠️
...ackages/code-studio/src/styleguide/XComponents.tsx 81.25% 3 Missing ⚠️
...s/dashboard-core-plugins/src/panels/ChartPanel.tsx 81.81% 2 Missing ⚠️
...dashboard-core-plugins/src/panels/ConsolePanel.tsx 0.00% 1 Missing ⚠️
...d-core-plugins/src/panels/IrisGridPanelTooltip.tsx 0.00% 1 Missing ⚠️
packages/dashboard/src/layout/useDashboardPanel.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2137      +/-   ##
==========================================
+ Coverage   46.63%   46.73%   +0.09%     
==========================================
  Files         682      689       +7     
  Lines       38443    38490      +47     
  Branches     9580     9780     +200     
==========================================
+ Hits        17928    17988      +60     
+ Misses      20505    20450      -55     
- Partials       10       52      +42     
Flag Coverage Δ
unit 46.73% <76.47%> (+0.09%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

- Instead of using PanelEvent.OPEN directly and not getting any type safety, add functions for emitting, listening, and a hook to enforce type safety
@mofojed mofojed changed the base branch from main to feature/core-plugins-refactor July 15, 2024 15:11
@mofojed mofojed changed the base branch from feature/core-plugins-refactor to main July 15, 2024 15:11
@mofojed mofojed requested review from mattrunyon and removed request for mattrunyon July 15, 2024 15:23
@mofojed
Copy link
Copy Markdown
Member Author

mofojed commented Jul 15, 2024

PR #2144 for merging the latest changes into the feature branch. Then we'll merge the feature branch into main.

@mofojed mofojed closed this Jul 16, 2024
@github-actions github-actions Bot locked and limited conversation to collaborators Jul 16, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant