Skip to content

feat: Add functions for PanelEvent.OPEN#2144

Merged
mofojed merged 4 commits intodeephaven:feature/core-plugins-refactorfrom
mofojed:feature/core-plugins-refactor
Jul 16, 2024
Merged

feat: Add functions for PanelEvent.OPEN#2144
mofojed merged 4 commits intodeephaven:feature/core-plugins-refactorfrom
mofojed:feature/core-plugins-refactor

Conversation

@mofojed
Copy link
Copy Markdown
Member

@mofojed mofojed commented Jul 15, 2024

  • Instead of using PanelEvent.OPEN directly and not getting any type safety, add functions for emitting, listening, and a hook to enforce type safety
  • Add xcomponents to the styleguide

mofojed added 3 commits July 15, 2024 11:25
- Instead of using PanelEvent.OPEN directly and not getting any type safety, add functions for emitting, listening, and a hook to enforce type safety
@codecov
Copy link
Copy Markdown

codecov Bot commented Jul 15, 2024

Codecov Report

Attention: Patch coverage is 27.27273% with 8 lines in your changes missing coverage. Please review.

Project coverage is 46.71%. Comparing base (b186ccf) to head (b3df572).

Files Patch % Lines
packages/code-studio/src/main/AppMainContainer.tsx 0.00% 6 Missing ⚠️
...dashboard-core-plugins/src/panels/ConsolePanel.tsx 0.00% 1 Missing ⚠️
packages/dashboard/src/layout/useDashboardPanel.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@                        Coverage Diff                        @@
##           feature/core-plugins-refactor    #2144      +/-   ##
=================================================================
- Coverage                          46.71%   46.71%   -0.01%     
=================================================================
  Files                                689      690       +1     
  Lines                              38521    38526       +5     
  Branches                            9814     9727      -87     
=================================================================
+ Hits                               17996    17997       +1     
- Misses                             20473    20477       +4     
  Partials                              52       52              
Flag Coverage Δ
unit 46.71% <27.27%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Comment thread packages/dashboard/src/PanelEvent.ts Outdated
Comment thread packages/dashboard/src/PanelEvent.ts Outdated
Comment thread packages/dashboard/src/PanelEvent.ts Outdated
Comment thread packages/golden-layout/src/utils/EventUtils.test.ts
Comment thread packages/golden-layout/src/utils/EventUtils.test.ts
Comment thread packages/golden-layout/src/utils/index.ts
- Clarify some of the comments
- Add more unit tests
@mofojed mofojed requested a review from mattrunyon July 16, 2024 14:16
@mofojed mofojed merged commit cbd2b1e into deephaven:feature/core-plugins-refactor Jul 16, 2024
@mofojed mofojed deleted the feature/core-plugins-refactor branch July 16, 2024 18:14
@github-actions github-actions Bot locked and limited conversation to collaborators Jul 16, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants