chore: DH-19612: cherry-pick indicator fixes#2460
Merged
jnumainville merged 2 commits intodeephaven:release/v0.85from Jun 11, 2025
Merged
chore: DH-19612: cherry-pick indicator fixes#2460jnumainville merged 2 commits intodeephaven:release/v0.85from
jnumainville merged 2 commits intodeephaven:release/v0.85from
Conversation
It appears that decimal and integer format options weren't correctly passing through so the chart was not receiving updates.
Adds theme variables for indicator
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## release/v0.85 #2460 +/- ##
=================================================
- Coverage 47.09% 47.09% -0.01%
=================================================
Files 702 702
Lines 39148 39150 +2
Branches 9770 9960 +190
=================================================
Hits 18436 18436
- Misses 20701 20703 +2
Partials 11 11
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
mofojed
approved these changes
Jun 11, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes from #2344 and #2353