Skip to content

DH-11788: Enable count aggregations for non-rollups#331

Merged
dsmmcken merged 1 commit intomainfrom
dmckenzie_DH-11788
Dec 7, 2021
Merged

DH-11788: Enable count aggregations for non-rollups#331
dsmmcken merged 1 commit intomainfrom
dmckenzie_DH-11788

Conversation

@dsmmcken
Copy link
Contributor

@dsmmcken dsmmcken commented Dec 7, 2021

Count now works as an aggregation for non-rollups. There are no longer any that are rollup exclusively. Leaving code to allow it in future in case any new rollup only aggregation method gets added.

@dsmmcken dsmmcken requested a review from mofojed December 7, 2021 18:57
@dsmmcken dsmmcken added the enhancement New feature or request label Dec 7, 2021
@codecov
Copy link

codecov bot commented Dec 7, 2021

Codecov Report

Merging #331 (9fa52ab) into main (1a9f7fb) will decrease coverage by 14.36%.
The diff coverage is 0.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##             main     #331       +/-   ##
===========================================
- Coverage   39.67%   25.30%   -14.37%     
===========================================
  Files         328        2      -326     
  Lines       23250      735    -22515     
  Branches     4790      329     -4461     
===========================================
- Hits         9224      186     -9038     
+ Misses      13573      468    -13105     
+ Partials      453       81      -372     
Flag Coverage Δ
unit 25.30% <0.00%> (-14.37%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
packages/iris-grid/src/TableUtils.js 24.25% <0.00%> (-42.23%) ⬇️
...-grid/src/sidebar/aggregations/AggregationUtils.ts 47.05% <ø> (-6.79%) ⬇️
packages/chart/src/ChartUtils.js
packages/code-studio/src/log/LogExport.ts
packages/components/src/AutoResizeTextarea.tsx
packages/grid/src/GridMetricCalculator.ts
packages/grid/src/GridRange.ts
packages/grid/src/GridRenderer.js
... and 319 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 113f731...9fa52ab. Read the comment docs.

@mofojed mofojed added enhancement New feature or request and removed enhancement New feature or request labels Dec 7, 2021
@dsmmcken dsmmcken merged commit fadd327 into main Dec 7, 2021
@dsmmcken dsmmcken deleted the dmckenzie_DH-11788 branch December 7, 2021 19:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants