Skip to content

DH-11788: Enable count aggregations for non-rollups #331

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dsmmcken merged 1 commit into from
Dec 7, 2021
Merged

DH-11788: Enable count aggregations for non-rollups #331

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions packages/iris-grid/src/sidebar/aggregations/AggregationUtils.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,8 +8,7 @@ import AggregationOperation from './AggregationOperation';
*/
export const isRollupOperation = (type: AggregationOperation): boolean => {
switch (type) {
case AggregationOperation.COUNT:
return true;
// currently no rollup only operations, but there has been in the past
default:
return false;
}
Expand Down