[Deepin-Kernel-SIG] [linux 6.6-y] [3SNIC] SCSI: SSSRAID: Support 3SNIC 3S5XX serial RAID/HBA

[Avenger-285714]

Add 3SNIC SSSRAID controller support.

Co-developed-by: fei zhigang feizg@3snic.com

[sourcery-ai]

Sorry @Avenger-285714, you have reached your weekly rate limit of 500000 diff characters.

Please try again later or upgrade to continue using Sourcery

[Copilot]

Pull request overview

This pull request adds support for the 3SNIC SSSRAID controller driver, a SCSI RAID driver for 3S5XX series controllers. The driver provides support for PCI Express Gen4 interface controllers with SAS/SATA HDD/SSD support, implementing both HBA and RAID functionality.

Key changes:

• New SCSI driver implementation with ~4,159 lines of code across multiple files
• Complete controller initialization, queue management, and I/O path implementation
• Support for admin and I/O command queues with interrupt handling
• Device discovery, management, and event handling capabilities

Reviewed changes

Copilot reviewed 10 out of 10 changed files in this pull request and generated no comments.

Show a summary per file

File	Description
drivers/scsi/sssraid/sssraid_os.c	Main driver file with SCSI callbacks, I/O handling, and device management
drivers/scsi/sssraid/sssraid_fw.c	Firmware interaction, queue setup, and admin command handling
drivers/scsi/sssraid/sssraid.h	Driver structures, constants, and function declarations
drivers/scsi/sssraid/sssraid_debug.h	Debug logging macros
drivers/scsi/sssraid/Kconfig	Kernel configuration for the driver
drivers/scsi/sssraid/Makefile	Build configuration
drivers/scsi/Kconfig	Integration into SCSI subsystem
drivers/scsi/Makefile	Build system integration
MAINTAINERS	Maintainer information for the driver
Documentation/scsi/sssraid.rst	Driver documentation

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[deepin-ci-robot]

deepin pr auto review

我来帮你分析这个SCSI RAID驱动的代码。这个驱动实现了对3SNIC RAID控制器的支持。我会从几个方面进行分析：

1. 代码结构和组织

2. 关键功能实现

3. 性能和安全考虑

4. 改进建议

5. 代码结构和组织

代码组织良好，主要分为几个关键文件：

• sssraid.h：主要数据结构和宏定义
• sssraid_debug.h：调试相关定义
• sssraid_fw.c：固件接口实现
• sssraid_os.c：操作系统接口实现

2. 关键功能实现

a) 队列管理

• 实现了多队列架构，支持admin队列和I/O队列
• 使用了MSI-X中断支持
• 实现了完整的命令提交和完成机制

b) 设备管理

• 支持HBA和RAID两种模式
• 实现了设备扫描、添加、删除等操作
• 支持多种RAID级别(0,1,5,6,10,50,60)

c) 错误处理

• 实现了超时处理
• 支持设备重置
• 实现了PCIe错误恢复机制

3. 性能和安全考虑

优点：

• 使用了DMA池管理内存
• 实现了SGL(Scatter Gather List)支持
• 支持多队列并行处理
• 实现了中断亲和性

潜在问题：

• 缺少一些边界检查
• 某些错误处理可以更完善

4. 改进建议

a) 代码质量改进：

// 建议在sssraid_setup_prps中添加更严格的边界检查
if (unlikely(length <= 0 || length > max_transfer_length)) {
    ioc_err(sdioc, "Invalid transfer length: %d\n", length);
    return -EINVAL;
}

b) 性能优化：

// 建议优化队列分配逻辑，减少内存碎片
static int sssraid_alloc_qpair(struct sssraid_ioc *sdioc, u16 qidx, u16 depth)
{
    // 使用连续内存分配
    void *mem = dma_alloc_coherent(&sdioc->pdev->dev, 
                                  CQ_SIZE(depth) + SQ_SIZE(qidx, depth),
                                  &dma_addr, GFP_KERNEL);
    if (!mem)
        return -ENOMEM;
        
    // 分配CQ和SQ在连续内存中
    cqinfo->cqes = mem;
    sqinfo->sq_cmds = mem + CQ_SIZE(depth);
    // ...
}

c) 安全性增强：

// 建议添加更严格的输入验证
static int sssraid_user_admin_cmd(struct sssraid_ioc *sdioc, struct bsg_job *job)
{
    if (!job || !job->request || job->request_len != sizeof(struct sssraid_bsg_request)) {
        ioc_err(sdioc, "Invalid BSG request\n");
        return -EINVAL;
    }
    
    // 验证命令参数
    if (cmd->timeout_ms > MAX_TIMEOUT_MS) {
        ioc_err(sdioc, "Invalid timeout value: %u\n", cmd->timeout_ms);
        return -EINVAL;
    }
    // ...
}

d) 错误处理改进：

// 建议完善错误恢复机制
static int sssraid_scsi_reset(struct scsi_cmnd *scmd, enum sssraid_scsi_rst_type rst)
{
    int ret;
    unsigned long flags;
    
    spin_lock_irqsave(&sdioc->state_lock, flags);
    if (sdioc->state != SSSRAID_LIVE) {
        spin_unlock_irqrestore(&sdioc->state_lock, flags);
        return FAILED;
    }
    
    // 添加重试机制
    for (int retry = 0; retry < MAX_RESET_RETRIES; retry++) {
        ret = sssraid_send_reset_cmd(sdioc, rst, hostdata->hdid);
        if (ret == 0)
            break;
            
        msleep(RESET_RETRY_DELAY);
    }
    
    spin_unlock_irqrestore(&sdioc->state_lock, flags);
    // ...
}

5. 其他建议

a) 添加更多调试信息：

#define ioc_debug(ioc, fmt, ...) \
    do { \
        if (ioc->logging_level & SSSRAID_DEBUG) \
            dev_dbg(&ioc->pdev->dev, fmt, ##__VA_ARGS__); \
    } while (0)

b) 优化内存使用：

// 使用内存池减少动态分配
static struct kmem_cache *sssraid_cmd_cache;

static int sssraid_init_cmd_cache(void)
{
    sssraid_cmd_cache = kmem_cache_create("sssraid_cmd",
                                         sizeof(struct sssraid_cmd),
                                         0, SLAB_HWCACHE_ALIGN, NULL);
    return sssraid_cmd_cache ? 0 : -ENOMEM;
}

c) 改进热插拔支持：

// 添加设备状态监控
static void sssraid_monitor_devices(struct work_struct *work)
{
    struct sssraid_ioc *sdioc = container_of(work, struct sssraid_ioc, monitor_work);
    
    // 定期检查设备状态
    sssraid_check_device_status(sdioc);
    
    // 重新调度监控
    schedule_delayed_work(&sdioc->monitor_work, 
                         msecs_to_jiffies(DEVICE_MONITOR_INTERVAL));
}

这些改进建议主要围绕：

1. 增强代码健壮性
2. 提高运行性能
3. 改进错误处理
4. 优化资源使用
5. 增加可维护性

建议在实现这些改进时进行充分的测试，确保不会影响现有功能的稳定性。

[Avenger-285714]

Tested and passed on x86 using LLVM-20.

I don’t have Deepin’s development environment (build toolchain), so I can’t update the defconfig for all architectures myself — could the Deepin team please handle this? Many thanks! @opsiff

[deepin-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: opsiff

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• deepin/OWNERS [opsiff]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[Avenger-285714]

Note: that was my oversight. There should be at least a "|| COMPILE_TEST" here.