[Deepin-Kernel-SIG] [linux 6.6-y] [Deepin] deepin: config: enable 3snic sssraid

[opsiff]

deepin inclusion
category: feature

SSSRAID - 3SNIC SCSI RAID Controller driver

PCI ID (pci.ids) OEM Product
1F3F:2100 3SNIC 3S510(HBA:8Ports,1G DDR)
1F3F:2100 3SNIC 3S520(HBA:16Ports,1G DDR)
1F3F:2100 3SNIC 3S530(HBA:32Ports,1G DDR)
1F3F:2100 3SNIC 3S540(HBA:40Ports,1G DDR)
1F3F:2200 3SNIC 3S580(RAID:16Ports,2G cache)
1F3F:2200 3SNIC 3S585(RAID:16Ports,4G cache)
1F3F:2200 3SNIC 3S590(RAID:32Ports,4G cache)
1F3F:2200 3SNIC 3S5A0(RAID:40Ports,2G cache)
1F3F:2200 3SNIC 3S5A5(RAID:40Ports,4G cache)

pci_device_id:
{ PCI_DEVICE(PCI_VENDOR_ID_3SNIC_LOGIC, SSSRAID_SERVER_DEVICE_HBA_DID) }, { PCI_DEVICE(PCI_VENDOR_ID_3SNIC_LOGIC, SSSRAID_SERVER_DEVICE_RAID_DID) },

Link: #1355

Summary by Sourcery

Enable support for the 3SNIC SSSRAID SCSI RAID controller driver in Deepin desktop kernel configurations for both arm64 and x86.

New Features:

• Add 3SNIC SSSRAID SCSI RAID controller driver to the default Deepin arm64 desktop kernel configuration.
• Add 3SNIC SSSRAID SCSI RAID controller driver to the default Deepin x86 desktop kernel configuration.

[sourcery-ai]

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

This PR enables the 3SNIC SSSRAID SCSI RAID controller driver in both x86 and arm64 Deepin desktop kernel defconfigs so the hardware is supported out of the box.

File-Level Changes

Change	Details	Files
Enable the 3SNIC SSSRAID controller driver in Deepin desktop kernel configurations for arm64 and x86.	Set the SSSRAID driver Kconfig option from disabled to built-in or module in the arm64 desktop defconfig. Set the SSSRAID driver Kconfig option from disabled to built-in or module in the x86 desktop defconfig. Ensure the new configuration symbol is consistent with upstream Kconfig naming for the 3SNIC SSSRAID controller driver.	arch/arm64/configs/deepin_arm64_desktop_defconfig arch/x86/configs/deepin_x86_desktop_defconfig

---

Tips and commands

Interacting with Sourcery

• Trigger a new review: Comment @sourcery-ai review on the pull request.
• Continue discussions: Reply directly to Sourcery's review comments.
• Generate a GitHub issue from a review comment: Ask Sourcery to create an
  issue from a review comment by replying to it. You can also reply to a
  review comment with @sourcery-ai issue to create an issue from it.
• Generate a pull request title: Write @sourcery-ai anywhere in the pull
  request title to generate a title at any time. You can also comment
  @sourcery-ai title on the pull request to (re-)generate the title at any time.
• Generate a pull request summary: Write @sourcery-ai summary anywhere in
  the pull request body to generate a PR summary at any time exactly where you
  want it. You can also comment @sourcery-ai summary on the pull request to
  (re-)generate the summary at any time.
• Generate reviewer's guide: Comment @sourcery-ai guide on the pull
  request to (re-)generate the reviewer's guide at any time.
• Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
  pull request to resolve all Sourcery comments. Useful if you've already
  addressed all the comments and don't want to see them anymore.
• Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
  request to dismiss all existing Sourcery reviews. Especially useful if you
  want to start fresh with a new review - don't forget to comment
  @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

• Enable or disable review features such as the Sourcery-generated pull request
  summary, the reviewer's guide, and others.
• Change the review language.
• Add, remove or edit custom review instructions.
• Adjust other review settings.

Getting Help

• Contact our support team for questions or feedback.
• Visit our documentation for detailed guides and information.
• Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

[deepin-ci-robot]

deepin pr auto review

这是一个Linux内核配置文件的差异(diff)，主要是在两个架构(arm64和x86)的桌面配置中都添加了一个新的SCSI RAID驱动配置项。让我来分析一下：

1. 语法逻辑：

• 语法正确，使用了标准的Linux内核配置格式
• 配置项位置合理，被放置在RAID相关的配置区域内
• 使用了"=m"表示该驱动将被编译为模块，这是推荐的做法

2. 代码质量：

• 配置项的命名符合Linux内核规范(CONFIG_SCSI_3SNIC_SSSRAID)
• 在两个架构的配置文件中都进行了相同的修改，保持了一致性
• 修改位置合适，与其他RAID驱动配置项放在一起

3. 代码性能：

• 作为配置文件修改，本身不会直接影响性能
• 将驱动编译为模块(m)而不是内置(y)是合理的做法，可以减少内核镜像大小，只在需要时加载

4. 代码安全：

• 添加新的驱动配置本身不会带来安全风险
• 建议确认3SNIC SSSRAID驱动的来源和安全性
• 建议确保该驱动已经过充分测试，特别是稳定性测试

改进建议：

1. 考虑添加配置项的帮助文本说明，解释这个驱动的用途
2. 建议在提交信息中说明添加这个驱动的原因和用途
3. 考虑是否需要添加相应的依赖项配置
4. 建议进行全面的测试，确保新驱动不会影响系统稳定性

总体来说，这个修改是合理的，但建议进行充分的测试验证。

[sourcery-ai]

Hey there - I've reviewed your changes and they look great!

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}

[Avenger-285714]

/approve

[deepin-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Avenger-285714

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• deepin/OWNERS [Avenger-285714]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[Copilot]

Pull request overview

This PR enables support for the 3SNIC SSSRAID SCSI RAID controller driver in Deepin's desktop kernel configurations for both x86 and arm64 architectures. The 3SNIC sssraid driver supports the 3S5xx series RAID controllers with PCI Express Gen4 interface, handling SAS/SATA HDD/SSD devices.

• Adds CONFIG_SCSI_3SNIC_SSSRAID=m to both x86 and arm64 desktop defconfig files
• Enables module support for various 3SNIC RAID controller models (3S510-3S5A5)

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File	Description
arch/x86/configs/deepin_x86_desktop_defconfig	Adds 3SNIC SSSRAID driver configuration as a module in the SCSI driver section
arch/arm64/configs/deepin_arm64_desktop_defconfig	Adds 3SNIC SSSRAID driver configuration as a module in the SCSI driver section

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.