fix(taskmill): atomic parent resolution and weak scheduler reference in TaskContext#22
Merged
Conversation
…in TaskContext Make try_resolve_parent run inside a single BEGIN IMMEDIATE transaction to eliminate the TOCTOU race where two children completing simultaneously could both trigger finalization. Change pending_finalizers from Vec to HashSet so duplicate enqueues are silently deduplicated. Replace the strong Arc<SchedulerInner> held by TaskContext with a Weak reference (WeakScheduler) so that spawned tasks no longer prevent the scheduler from being dropped during shutdown.
Merged
deepjoy
pushed a commit
that referenced
this pull request
Mar 14, 2026
## 🤖 New release * `taskmill`: 0.3.0 -> 0.3.1 (✓ API compatible changes) <details><summary><i><b>Changelog</b></i></summary><p> <blockquote> ## [0.3.1](v0.3.0...v0.3.1) - 2026-03-14 ### Fixed - scheduler performance and correctness improvements ([#24](#24)) - *(taskmill)* atomic parent resolution and weak scheduler reference in TaskContext ([#22](#22)) ### Other - *(taskmill)* split large modules into focused submodules and optimize completion hot path ([#25](#25)) - *(taskmill)* add integration tests and criterion benchmarks ([#21](#21)) </blockquote> </p></details> --- This PR was generated with [release-plz](https://github.com/release-plz/release-plz/). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Make try_resolve_parent run inside a single BEGIN IMMEDIATE transaction to eliminate the TOCTOU race where two children completing simultaneously could both trigger finalization. Change pending_finalizers from Vec to HashSet so duplicate enqueues are silently deduplicated.
Replace the strong Arc held by TaskContext with a Weak reference (WeakScheduler) so that spawned tasks no longer prevent the scheduler from being dropped during shutdown.