Conversation
…ate O(N²) progress fan-out Switch ActiveTaskMap from tokio::Mutex to std::sync::Mutex since most operations do trivial HashMap work with no .await. Restructure preempt_below and pause_all with two-phase locking (collect under sync lock, then async I/O). Give ProgressReporter a direct ActiveTaskMap handle to update progress inline, removing the per-task broadcast listener that caused O(N×M) wakeups across N tasks and M events.
…d atomize submit() - Replace strong `Scheduler` with `WeakScheduler` in `SpawnContext` to prevent keeping `SchedulerInner` alive during graceful shutdown - Track `JoinHandle`s in `ActiveTask` so shutdown can join spawned futures instead of polling `active.count()` in a busy loop - Wrap single-task `submit()` in `BEGIN IMMEDIATE` transaction to match `submit_batch()` and prevent non-atomic multi-statement races
Add missing work_notify.notify_one() calls after Completed and Failed event emissions so the scheduler loop wakes immediately to dispatch pending work instead of waiting for the next poll interval.
Merged
deepjoy
pushed a commit
that referenced
this pull request
Mar 14, 2026
## 🤖 New release * `taskmill`: 0.3.0 -> 0.3.1 (✓ API compatible changes) <details><summary><i><b>Changelog</b></i></summary><p> <blockquote> ## [0.3.1](v0.3.0...v0.3.1) - 2026-03-14 ### Fixed - scheduler performance and correctness improvements ([#24](#24)) - *(taskmill)* atomic parent resolution and weak scheduler reference in TaskContext ([#22](#22)) ### Other - *(taskmill)* split large modules into focused submodules and optimize completion hot path ([#25](#25)) - *(taskmill)* add integration tests and criterion benchmarks ([#21](#21)) </blockquote> </p></details> --- This PR was generated with [release-plz](https://github.com/release-plz/release-plz/). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
tokio::Mutexwithstd::sync::MutexinActiveTaskMap— most operations do trivialHashMapwork with no.await, so a sync mutex avoids unnecessary runtime interaction. Methods that need async I/O (preempt_below,pause_all) now use two-phase locking: collect under the sync lock, then release before awaiting.ProgressReporternow updates theActiveTaskMapdirectly via a sync call.Arccycle inSpawnContext— replace the strongSchedulerreference withWeakSchedulerto prevent keepingSchedulerInneralive during graceful shutdown.JoinHandles inActiveTask— shutdown can now join spawned futures instead of pollingactive.count()in a 50ms busy loop. Graceful shutdown joins each handle with a per-task timeout budget.submit()— wrap inBEGIN IMMEDIATEtransaction to matchsubmit_batch()and prevent non-atomic multi-statement races.work_notify.notify_one()calls afterCompletedandFailedevent emissions so the scheduler loop dispatches pending work immediately instead of waiting for the next poll interval.