refactor: eliminate stringly-typed history status and DRY violations#52
Merged
Conversation
deepjoy
force-pushed
the
internal-refactor
branch
2 times, most recently
from
97a2f35 to
d02e45f
Compare
Contributor
Benchmark ComparisonClick to expand |
deepjoy
force-pushed
the
internal-refactor
branch
from
d02e45f to
26cd7b0
Compare
…atus enum Introduces a sealed `HistoryStatus` enum with 7 variants (Completed, Failed, DeadLetter, Cancelled, Expired, Superseded, DependencyFailed), replacing the `status: &str` parameter on `insert_history`. The retry count increment now uses `status.increments_retries()` instead of a string comparison. All 8 call sites across lifecycle, hierarchy, and submit modules updated. No public API changes.
- Add TaskRecord::module_name() helper; replace 5 split_once("::") sites
in dispatch.rs and gate.rs
- Consolidate 6 ActiveTaskMap snapshot methods into 3 with Option<&str>
prefix parameter; update all 9 call sites
- Extract merge_module_tags() in SubmitBuilder; replace both duplicated
tag-merge loops in resolve()
deepjoy
force-pushed
the
internal-refactor
branch
from
26cd7b0 to
61cfe8a
Compare
Merged
deepjoy
pushed a commit
that referenced
this pull request
Mar 19, 2026
## 🤖 New release * `taskmill`: 0.5.0 -> 0.5.1 (✓ API compatible changes) <details><summary><i><b>Changelog</b></i></summary><p> <blockquote> ## [0.5.1](v0.5.0...v0.5.1) - 2026-03-19 ### Fixed - *(bench)* eliminate per-sample scheduler setup cost in history benchmarks ([#55](#55)) - *(bench)* remove premature cancellation token call in history benchmark setup ([#54](#54)) - *(ci)* bootstrap _benchmarks branch on first push to main ([#53](#53)) - *(ci)* restore stderr capture for benchmark output on main ([#51](#51)) - *(ci)* exclude lib target from cargo bench to fix benchmark CI ([#49](#49)) ### Other - decompose internal god objects into focused, single-responsibility modules ([#56](#56)) - eliminate stringly-typed history status and DRY violations ([#52](#52)) </blockquote> </p></details> --- This PR was generated with [release-plz](https://github.com/release-plz/release-plz/). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
insert_history(status: &str)with aHistoryStatusenum — typos nowfail at compile time and the
increments_retries()predicate replaces a stringcomparison across 7 call sites
TaskRecord::module_name()helper and replace 5 identicalsplit_once("::")expressions in
dispatch.rsandgate.rsActiveTaskMapsnapshot methods (records,progress_snapshots,byte_progress_snapshots+ their_with_prefixvariants) into 3 that acceptOption<&str>; update all 9 call sitesmerge_module_tags()inSubmitBuilderand replace both duplicatedtag-merge loops in
resolve()Notes
pub(crate)) changes only — no public API surface affected