refactor: decompose internal god objects into focused, single-responsibility modules#56
Merged
Conversation
Break the 380-line spawn_task god function into testable units: - spawn/context.rs: SpawnContext + TaskContext construction - spawn/completion.rs: success path (children, recurring, dependencies) - spawn/failure.rs: failure path (retry, dead-letter, fail-fast cascade) - spawn/parent.rs: parent-child resolution - spawn.rs: slim ~85-line orchestrator Also DRY up ActiveTaskMap bulk operations (preempt_below, pause_module, pause_all) with a shared drain_where helper and cancel_pause_emit.
Move dependency graph operations (resolve_dependents, fail_dependents) out of lifecycle/ into store/dependencies.rs since they operate on the dep graph, not task lifecycle states. Consolidate pop, complete, and fail into lifecycle/transitions.rs to make the state machine visible in one place. Add clear section headers to cancel_expire.rs.
…thods Split the monolithic resolve() into four named methods that each own one layer of the 5-layer precedence chain: - apply_prefix: module name prefixing - apply_defaults: layers 2–4 (TypedTask / submission / module defaults) - apply_module_scalar_defaults: shared priority/group/TTL logic for both typed and untyped paths (eliminates duplicated conditional blocks) - apply_overrides: layer 1 per-call builder overrides No external API or behavioral change — all existing tests pass unchanged.
Merged
deepjoy
pushed a commit
that referenced
this pull request
Mar 19, 2026
## 🤖 New release * `taskmill`: 0.5.0 -> 0.5.1 (✓ API compatible changes) <details><summary><i><b>Changelog</b></i></summary><p> <blockquote> ## [0.5.1](v0.5.0...v0.5.1) - 2026-03-19 ### Fixed - *(bench)* eliminate per-sample scheduler setup cost in history benchmarks ([#55](#55)) - *(bench)* remove premature cancellation token call in history benchmark setup ([#54](#54)) - *(ci)* bootstrap _benchmarks branch on first push to main ([#53](#53)) - *(ci)* restore stderr capture for benchmark output on main ([#51](#51)) - *(ci)* exclude lib target from cargo bench to fix benchmark CI ([#49](#49)) ### Other - decompose internal god objects into focused, single-responsibility modules ([#56](#56)) - eliminate stringly-typed history status and DRY violations ([#52](#52)) </blockquote> </p></details> --- This PR was generated with [release-plz](https://github.com/release-plz/release-plz/). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
spawn_taskgod function — break the 380-line function intofocused submodules (
spawn/context.rs,spawn/completion.rs,spawn/failure.rs,spawn/parent.rs) with an ~85-line orchestrator; DRY upActiveTaskMapbulk operations with a shareddrain_wherehelperTaskStoreinto focused services — move dependency-graphoperations to
store/dependencies.rs, consolidatepop/complete/failinto
lifecycle/transitions.rsso the state machine is visible in one placeSubmitBuilder::resolveprecedence chain — split intoapply_prefix,apply_defaults,apply_module_scalar_defaults, andapply_overrides; unify the duplicated typed/untyped module-defaults logicNo external API surface change.