fix: use distinct critcmp group names for PR benchmark comparison#72
Merged
Conversation
The baseline and PR benchmarks were both exported under the group name "current", causing critcmp to merge them into a single column instead of producing a side-by-side comparison with ratios.
Merged
deepjoy
added a commit
that referenced
this pull request
Mar 22, 2026
- PR #72 introduced `critcmp --import` which doesn't exist, causing the "Compare benchmarks" step to fail on every PR - Pass the exported JSON files directly as positional arguments (`critcmp baseline.json pr.json`), which is the supported way to compare two baselines
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
current, causingcritcmpto merge them into a single column instead of producing a two-column comparison with ratios.mainbefore comparing, socritcmpsees two distinct groups (mainvscurrent) and renders a proper side-by-side diff.