Skip to content

fix: use distinct critcmp group names for PR benchmark comparison#74

Merged
deepjoy merged 1 commit into
mainfrom
fail-fast
Mar 22, 2026
Merged

fix: use distinct critcmp group names for PR benchmark comparison#74
deepjoy merged 1 commit into
mainfrom
fail-fast

Conversation

@deepjoy
Copy link
Copy Markdown
Owner

@deepjoy deepjoy commented Mar 22, 2026

critcmp compares exported JSON files by passing them as positional
arguments. The previous commit incorrectly used a non-existent
--import flag. Pass baseline.json and pr.json directly instead.
@deepjoy deepjoy enabled auto-merge (squash) March 22, 2026 03:37
@deepjoy deepjoy merged commit d3f9935 into main Mar 22, 2026
2 checks passed
@github-actions github-actions Bot mentioned this pull request Mar 22, 2026
@github-actions
Copy link
Copy Markdown
Contributor

Benchmark Comparison

Click to expand
group                                       current
-----                                       -------
backoff_delay/constant                      1.00     50.1±0.06ns        ? ?/sec
backoff_delay/exponential                   1.00    218.5±0.60ns        ? ?/sec
backoff_delay/exponential_jitter            1.00    383.7±1.66ns        ? ?/sec
backoff_delay/linear                        1.00     82.5±1.45ns        ? ?/sec
batch_submit_1000                           1.00     30.0±1.75ms        ? ?/sec
byte_progress/byte_reporting_500            1.00    221.5±2.68ms        ? ?/sec
byte_progress/noop_500                      1.00    217.7±3.54ms        ? ?/sec
byte_progress_snapshot_100_tasks            1.00     73.8±1.89ms        ? ?/sec
concurrency_scaling/1                       1.00    347.0±3.41ms        ? ?/sec
concurrency_scaling/2                       1.00    285.9±3.16ms        ? ?/sec
concurrency_scaling/4                       1.00    248.8±6.32ms        ? ?/sec
concurrency_scaling/8                       1.00    218.6±3.82ms        ? ?/sec
count_by_tags/100                           1.00    117.8±3.64µs        ? ?/sec
count_by_tags/1000                          1.00    191.2±3.44µs        ? ?/sec
count_by_tags/5000                          1.00    522.7±4.86µs        ? ?/sec
dep_chain_dispatch/10                       1.00     10.1±0.09ms        ? ?/sec
dep_chain_dispatch/25                       1.00     24.4±0.25ms        ? ?/sec
dep_chain_dispatch/50                       1.00     48.4±0.47ms        ? ?/sec
dep_chain_submit/10                         1.00      3.0±0.14ms        ? ?/sec
dep_chain_submit/200                        1.00     69.4±3.44ms        ? ?/sec
dep_chain_submit/50                         1.00     15.8±0.89ms        ? ?/sec
dep_fan_in_dispatch/10                      1.00      6.5±0.05ms        ? ?/sec
dep_fan_in_dispatch/100                     1.00     47.2±0.80ms        ? ?/sec
dep_fan_in_dispatch/50                      1.00     24.7±0.31ms        ? ?/sec
dispatch_and_complete_1000                  1.00    437.4±5.18ms        ? ?/sec
dispatch_group_scaling/1                    1.00    376.7±4.63ms        ? ?/sec
dispatch_group_scaling/10                   1.00    376.0±4.43ms        ? ?/sec
dispatch_group_scaling/100                  1.00    375.1±3.99ms        ? ?/sec
dispatch_group_scaling/50                   1.00    377.0±4.41ms        ? ?/sec
dispatch_no_groups_500                      1.00    217.9±4.38ms        ? ?/sec
dispatch_one_group_500                      1.00    376.8±4.76ms        ? ?/sec
dispatch_permanent_failure_500              1.00    336.3±3.49ms        ? ?/sec
history_by_type/100                         1.00  1162.4±21.57µs        ? ?/sec
history_by_type/1000                        1.00  1154.3±12.50µs        ? ?/sec
history_by_type/5000                        1.00  1214.8±34.56µs        ? ?/sec
history_query/100                           1.00   635.5±10.41µs        ? ?/sec
history_query/1000                          1.00    643.5±4.09µs        ? ?/sec
history_query/5000                          1.00   694.1±11.41µs        ? ?/sec
history_stats/100                           1.00    133.2±0.52µs        ? ?/sec
history_stats/1000                          1.00    326.2±0.75µs        ? ?/sec
history_stats/5000                          1.00   1181.2±2.90µs        ? ?/sec
mixed_priority_dispatch_500                 1.00    247.7±5.87ms        ? ?/sec
peek_next/100                               1.00    115.4±2.71µs        ? ?/sec
peek_next/1000                              1.00    116.4±2.18µs        ? ?/sec
peek_next/5000                              1.00    115.9±3.06µs        ? ?/sec
query_by_tags/100                           1.00  1343.9±61.02µs        ? ?/sec
query_by_tags/1000                          1.00     12.1±0.88ms        ? ?/sec
query_by_tags/5000                          1.00     65.6±5.42ms        ? ?/sec
retryable_dead_letter/constant              1.00    138.1±1.49ms        ? ?/sec
retryable_dead_letter/exponential           1.00    137.9±1.49ms        ? ?/sec
retryable_dead_letter/exponential_jitter    1.00    138.3±1.40ms        ? ?/sec
retryable_dead_letter/linear                1.00    138.4±1.55ms        ? ?/sec
submit_1000_tasks                           1.00    167.0±5.26ms        ? ?/sec
submit_dedup_hit_1000                       1.00    217.7±6.63ms        ? ?/sec
submit_with_tags/0                          1.00     83.0±3.16ms        ? ?/sec
submit_with_tags/10                         1.00    217.8±6.30ms        ? ?/sec
submit_with_tags/20                         1.00   350.8±11.36ms        ? ?/sec
submit_with_tags/5                          1.00    150.9±4.97ms        ? ?/sec
tag_values/100                              1.00    126.0±3.22µs        ? ?/sec
tag_values/1000                             1.00    186.1±3.30µs        ? ?/sec
tag_values/5000                             1.00    449.7±3.84µs        ? ?/sec

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant