The last six hand-rolled dialogs become Dialog - #386
Merged
Conversation
Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Signed-off-by: WaylandYang <wayland0916@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #384.
The five hand-rolled dialogs in the library (extraction drops, error text, ingest token, new source, source settings) and the one in Settings (new knowledge base) are now
Dialog. Bodies unchanged; each lost its own scrim, panel, header, close cross, footer strip,Escapelistener and scrim mouse-down check, and gained what Radix gives everyDialog: focus trapped inside,role="dialog"with a title and description, Escape and scrim click that close it, and the near-solidu-modal-panelskin instead of glass. Titles, descriptions and footers moved into the component's slots; the ingest-token title keeps its key icon; the source-settings dialog's delete confirmation stays nested and Radix's layering lets only the top one answer Escape. Widths come off the three-step scale —smfor the new base,mdfor the rest.Verified in the browser: New source opens as a 512 px
role="dialog"with all twelve kinds and closes on Escape; New knowledge base opens at 384 px with its inputs and pack cards and closes on Escape and on a scrim click.pnpm buildpasses; nou-modal-scrimis left in a page.🤖 Generated with Claude Code