update unit test#23
Merged
Merged
Conversation
QG-phy
added a commit
to QG-phy/DeePTB
that referenced
this pull request
Jun 25, 2026
job2 depended on build only to echo unset/removed outputs ($OUTPUT1 was never declared in env; $OUTPUT2/$OUTPUT3 came from build outputs that the build steps never set — output3 was deleted back in deepmodeling#23 but job2's reference was left). It ran ~9s per PR with no effect. Drop job2 and the now-unread build outputs block.
QG-phy
added a commit
that referenced
this pull request
Jun 25, 2026
* Fix two runtime warnings: non-writable array and docstring escape - _default_dataset.py: h5py-backed arrays are read-only, so torch.as_tensor emitted "NumPy array is not writable" when converting kpoint/eigenvalue data. Add .copy() to produce a writable array before the tensor conversion. - test_feast_wrapper.py: the docstring "Ax = \lambda Mx" used an invalid escape sequence (SyntaxWarning on Python 3.12+). Switch to a raw string. Local not-slow run: warnings drop 84 -> 75, 447 passed, 0 failed. The remaining warnings are all external-library debt (pythtb 1.x->2.x migration, spglib OLD_ERROR_HANDLING, ASE numpy 2.0 __array__, torch.jit) tracked in separate migration tasks. * Remove dead job2 from unit_test workflow job2 depended on build only to echo unset/removed outputs ($OUTPUT1 was never declared in env; $OUTPUT2/$OUTPUT3 came from build outputs that the build steps never set — output3 was deleted back in #23 but job2's reference was left). It ran ~9s per PR with no effect. Drop job2 and the now-unread build outputs block. * Rename unit_test job build -> test The job checks out the PR, installs DeePTB, and runs ut.sh. It does no build/compile step and produces no artifact, so "build" is a historical misnomer. Rename to "test". No branch-protection required checks reference the old name, and no other workflow/job reads this job by name.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
combine unit test command