Support non-ASCII (CJK) paths in Windows installer#7342
Merged
mohanchen merged 1 commit intoMay 14, 2026
Conversation
Force UTF-8 at the top of install-abacus.bat, uninstall-abacus.bat, and the generated abacus.cmd / abacus-mpi.cmd launchers via `chcp 65001` and `set WSL_UTF8=1`. Without these, wsl.exe emits UTF-16LE when its stdout is piped, so the `for /f` that captures `wslpath` output mangles any CJK characters in the repository or case directory path, and the launchers' `wsl --cd "%CD%"` fails from a Chinese-named directory. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
mohanchen
approved these changes
May 14, 2026
mohanchen
added
Refactor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Force UTF-8 at the top of install-abacus.bat, uninstall-abacus.bat, and the generated abacus.cmd / abacus-mpi.cmd launchers via
chcp 65001andset WSL_UTF8=1. Without these, wsl.exe emits UTF-16LE when its stdout is piped, so thefor /fthat captureswslpathoutput mangles any CJK characters in the repository or case directory path, and the launchers'wsl --cd "%CD%"fails from a Chinese-named directory.