Skip to content

Support non-ASCII (CJK) paths in Windows installer #7342

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mohanchen merged 1 commit into from
May 14, 2026
Merged

Support non-ASCII (CJK) paths in Windows installer #7342

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions tools/windows/install-abacus.bat
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,11 @@
@echo off
setlocal EnableExtensions EnableDelayedExpansion
REM Force UTF-8 so paths containing non-ASCII (e.g. CJK) characters survive
REM round-tripping through wsl.exe. WSL_UTF8 makes wsl.exe emit UTF-8 when
REM its stdout is piped (otherwise it emits UTF-16LE and `for /f` mangles
REM the result); chcp 65001 lets cmd decode that UTF-8 cleanly.
chcp 65001 >nul
set "WSL_UTF8=1"
title ABACUS for Windows (WSL2) Installer

set "DISTRO=Ubuntu-22.04"
Expand Down Expand Up @@ -128,10 +134,14 @@ REM --- 6. Install Windows-side launchers ---
if not exist "%BIN_DIR%" mkdir "%BIN_DIR%"

> "%BIN_DIR%\abacus.cmd" echo @echo off
>> "%BIN_DIR%\abacus.cmd" echo chcp 65001 ^>nul
>> "%BIN_DIR%\abacus.cmd" echo set "WSL_UTF8=1"
>> "%BIN_DIR%\abacus.cmd" echo set "WSLENV=OMP_NUM_THREADS:MKL_NUM_THREADS:OPENBLAS_NUM_THREADS:%%WSLENV%%"
>> "%BIN_DIR%\abacus.cmd" echo wsl -d %DISTRO% --cd "%%CD%%" -- abacus %%*

> "%BIN_DIR%\abacus-mpi.cmd" echo @echo off
>> "%BIN_DIR%\abacus-mpi.cmd" echo chcp 65001 ^>nul
>> "%BIN_DIR%\abacus-mpi.cmd" echo set "WSL_UTF8=1"
>> "%BIN_DIR%\abacus-mpi.cmd" echo set "WSLENV=OMP_NUM_THREADS:MKL_NUM_THREADS:OPENBLAS_NUM_THREADS:%%WSLENV%%"
>> "%BIN_DIR%\abacus-mpi.cmd" echo wsl -d %DISTRO% --cd "%%CD%%" -- abacus-mpi %%*

Expand Down
4 changes: 4 additions & 0 deletions tools/windows/uninstall-abacus.bat
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,9 @@
@echo off
setlocal EnableExtensions EnableDelayedExpansion
REM Force UTF-8 so paths with non-ASCII (e.g. CJK) characters survive
REM round-tripping through wsl.exe (see install-abacus.bat for details).
chcp 65001 >nul
set "WSL_UTF8=1"
title ABACUS Uninstaller

set "DISTRO=Ubuntu-22.04"
Expand Down
Loading