Skip to content

Conversation

@jamesbhobbs
Copy link
Contributor

@jamesbhobbs jamesbhobbs commented Oct 10, 2025

chore: sync strict TypeScript compiler flags from deepnote/deepnote

Summary

Adds two strict TypeScript compiler flags to align jupyterlab-deepnote's configuration with deepnote/deepnote:

  • forceConsistentCasingInFileNames: Ensures import paths match exact file casing (helps catch cross-platform issues)
  • skipLibCheck: Skips type checking of declaration files for faster builds

This is part of a broader effort to synchronize tooling configurations across deepnote/deepnote, jupyterlab-deepnote, and vscode-deepnote repositories.

Review & Testing Checklist for Human

  • Verify flag selection: Confirm these are the correct flags to sync from deepnote/deepnote's tsconfig.json (no other important differences missed)
  • CI validation: Ensure all CI checks pass, particularly TypeScript compilation and any downstream build processes
  • Integration testing: Test that the extension still builds and loads correctly in JupyterLab after the changes

Notes

Summary by CodeRabbit

  • Chores
    • Updated TypeScript configuration to improve build reliability and cross-platform consistency by enforcing consistent file name casing.
    • Optimized developer experience and build times by skipping type checks for external library declarations.
    • No changes to application functionality or user-facing behavior; these updates target development workflow and stability.

- Add forceConsistentCasingInFileNames to ensure import paths match exact file casing
- Add skipLibCheck to skip type checking of declaration files for faster builds

These flags align with the strict configuration used in deepnote/deepnote
and improve type safety and consistency across the codebase.
@devin-ai-integration
Copy link

🤖 Devin AI Engineer

I'll be helping with this pull request! Here's what you should know:

✅ I will automatically:

  • Address comments on this PR that start with 'DevinAI' or '@devin'.
  • Look at CI failures and help fix them

⚙️ Control Options:

  • Disable automatic comment and CI monitoring

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Oct 10, 2025

📝 Walkthrough

Walkthrough

Added two TypeScript compiler options in tsconfig.json: forceConsistentCasingInFileNames (enforces consistent file name casing) and skipLibCheck (skips type-checking of .d.ts from libraries). No changes to code or exported APIs; only compiler configuration and error-checking behavior updated.

Possibly related PRs

Suggested reviewers

  • Artmann
  • saltenasl
  • andyjakubowski

Pre-merge checks

✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title Check ✅ Passed The title clearly describes the synchronization of TypeScript compiler flags with the upstream deepnote/deepnote repository, which matches the changes present in the tsconfig.json file. It is concise and specific regarding the nature of the change. It informs reviewers of the chore nature and the source of configuration updates without unnecessary detail.
Docstring Coverage ✅ Passed No functions found in the changes. Docstring coverage check skipped.

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: ASSERTIVE

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between b865e79 and 03ccc48.

📒 Files selected for processing (1)
  • tsconfig.json (2 hunks)
🧰 Additional context used
🧠 Learnings (1)
📓 Common learnings
Learnt from: CR
PR: deepnote/deepnote-internal#0
File: CONVENTIONS.md:0-0
Timestamp: 2025-09-30T12:33:33.332Z
Learning: Applies to **/*.{ts,tsx} : Boolean options are non-nullable; other options generally nullable
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (3)
  • GitHub Check: build
  • GitHub Check: Lint & Format
  • GitHub Check: check_release

Comment @coderabbitai help to get the list of available commands and usage tips.

@codecov
Copy link

codecov bot commented Oct 10, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 18.50%. Comparing base (88fd175) to head (e5fdca9).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #23   +/-   ##
=======================================
  Coverage   18.50%   18.50%           
=======================================
  Files          13       13           
  Lines         200      200           
  Branches       27       27           
=======================================
  Hits           37       37           
  Misses        163      163           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@jamesbhobbs jamesbhobbs marked this pull request as ready for review October 14, 2025 15:14
@jamesbhobbs jamesbhobbs merged commit 5b55216 into main Oct 14, 2025
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants