-
Notifications
You must be signed in to change notification settings - Fork 0
chore: sync strict TypeScript compiler flags from deepnote/deepnote #23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: sync strict TypeScript compiler flags from deepnote/deepnote #23
Conversation
- Add forceConsistentCasingInFileNames to ensure import paths match exact file casing - Add skipLibCheck to skip type checking of declaration files for faster builds These flags align with the strict configuration used in deepnote/deepnote and improve type safety and consistency across the codebase.
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
⚙️ Control Options:
|
📝 WalkthroughWalkthroughAdded two TypeScript compiler options in tsconfig.json: forceConsistentCasingInFileNames (enforces consistent file name casing) and skipLibCheck (skips type-checking of .d.ts from libraries). No changes to code or exported APIs; only compiler configuration and error-checking behavior updated. Possibly related PRs
Suggested reviewers
Pre-merge checks✅ Passed checks (3 passed)
📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: ASSERTIVE Plan: Pro 📒 Files selected for processing (1)
🧰 Additional context used🧠 Learnings (1)📓 Common learnings⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (3)
Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #23 +/- ##
=======================================
Coverage 18.50% 18.50%
=======================================
Files 13 13
Lines 200 200
Branches 27 27
=======================================
Hits 37 37
Misses 163 163 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
chore: sync strict TypeScript compiler flags from deepnote/deepnote
Summary
Adds two strict TypeScript compiler flags to align jupyterlab-deepnote's configuration with deepnote/deepnote:
forceConsistentCasingInFileNames: Ensures import paths match exact file casing (helps catch cross-platform issues)skipLibCheck: Skips type checking of declaration files for faster buildsThis is part of a broader effort to synchronize tooling configurations across deepnote/deepnote, jupyterlab-deepnote, and vscode-deepnote repositories.
Review & Testing Checklist for Human
Notes
Summary by CodeRabbit